From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L2Y61-0003jW-Mp for qemu-devel@nongnu.org; Tue, 18 Nov 2008 16:26:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L2Y60-0003jJ-2Q for qemu-devel@nongnu.org; Tue, 18 Nov 2008 16:26:53 -0500 Received: from [199.232.76.173] (port=47773 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L2Y5z-0003jF-Tu for qemu-devel@nongnu.org; Tue, 18 Nov 2008 16:26:51 -0500 Received: from an-out-0708.google.com ([209.85.132.240]:32505) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L2Y60-0005ZJ-05 for qemu-devel@nongnu.org; Tue, 18 Nov 2008 16:26:52 -0500 Received: by an-out-0708.google.com with SMTP id c38so1230672ana.37 for ; Tue, 18 Nov 2008 13:26:51 -0800 (PST) Message-ID: <49233317.3080807@codemonkey.ws> Date: Tue, 18 Nov 2008 15:26:47 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v5 00/18] Enhance debugging support References: <20081117161857.26880.45423.stgit@mchn012c.ww002.siemens.net> In-Reply-To: <20081117161857.26880.45423.stgit@mchn012c.ww002.siemens.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Jan Kiszka wrote: > Here is the latest update after the recent review round. Addressed > issues: > Applied 1-14. Thanks for all your work! I took a pretty detailed look at patch 13. It seems pretty unlikely to me that it could cause regressions since we were basically ignoring debug registers before. I did some extra testing with it too. 15 looks fine but I want to see what the decision is wrt threads vs processes. I think vCont is a good example of why using threads may prove better than processes. I've provided additional comments on 16-18. Nothing major and if you update them, they can be applied quickly. > PS: If you happen to use git internally, you can also pull the series > from my private repository: > > git://git.kiszka.org/qemu.git gdb-queue > Son of a gun, I wish I would have seen that early. FYI, in general, if people have git repos based on the kernel.org repo, please let me know. It's a lot easier for me to pull those patches and git-svn the result instead of dealing with exporting mails and pulling them into SVN. Regards, Anthony Liguori > -- > Siemens AG, Corporate Technology, CT SE 2 ES-OS > Corporate Competence Center Embedded Linux > > >