From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L2YgM-0004j2-9O for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:04:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L2YgJ-0004iR-AV for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:04:25 -0500 Received: from [199.232.76.173] (port=56957 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L2YgJ-0004iM-6X for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:04:23 -0500 Received: from an-out-0708.google.com ([209.85.132.246]:40769) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L2YgJ-0001Lb-8a for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:04:23 -0500 Received: by an-out-0708.google.com with SMTP id c38so1238225ana.37 for ; Tue, 18 Nov 2008 14:04:22 -0800 (PST) Message-ID: <49233BDA.7030807@codemonkey.ws> Date: Tue, 18 Nov 2008 16:04:10 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support References: <1226956692-15962-1-git-send-email-hollisb@us.ibm.com> <09739678475eecbf3d9de512bf1dd13d07bd6642.1226955410.git.hollisb@us.ibm.com> <9d5d305c23980946944437d1116f3f83430b40e2.1226955410.git.hollisb@us.ibm.com> In-Reply-To: <9d5d305c23980946944437d1116f3f83430b40e2.1226955410.git.hollisb@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Hollis Blanchard Hollis Blanchard wrote: > Based on gzip uImage loading code from u-boot. > > Signed-off-by: Jerone Young > Signed-off-by: Hollis Blanchard > So you pulled some code out of gunzip? Presumably that's GPL'd and carries some sort of attribution? This file is licensed under the X11 license so this sort of change would be important. Also note that there are multiple implementations of unzip in QEMU right now so you could refactor one of those into common code. Regards, Anthony Liguori