From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L2YnI-0007I3-8V for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:11:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L2YnH-0007HV-ED for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:11:35 -0500 Received: from [199.232.76.173] (port=56379 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L2YnH-0007HP-6U for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:11:35 -0500 Received: from yx-out-1718.google.com ([74.125.44.158]:12803) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L2YnG-000233-Jh for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:11:34 -0500 Received: by yx-out-1718.google.com with SMTP id 3so1307334yxi.82 for ; Tue, 18 Nov 2008 14:11:33 -0800 (PST) Message-ID: <49233D90.107@codemonkey.ws> Date: Tue, 18 Nov 2008 16:11:28 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qemu: Fix incorrect zlib check error References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm-ppc@vger.kernel.org Hollis Blanchard wrote: > On Fri, Nov 14, 2008 at 11:57 AM, Deepa Srinivasan wrote: > >> qemu: Fix incorrect zlib check error >> >> From: Deepa Srinivasan >> >> Include the CFLAGS and LDFLAGS variables in the check for zlib. When cross-compiling >> for PowerPC, the path for zlib headers and libraries are passed in the CFLAGS >> and LDFLAGS respectively. While this patch fixes only the check for zlib, >> this issue potentially affects other configure tests as well. >> > > Doesn't anybody else cross-compile qemu? AFAICS, this patch is > required to specify the location of cross-built libraries like zlib. > That's if you're using --extra-cflags. I cross compile without using --extra-cflags by installing libraries in the path of the cross environment. For instance, I have a /usr/i586-mingw32msvc path and the include/ directory in their has a zlib.h. This is what will be used by default. Regards, Anthony Liguori > -Hollis > > >