From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L2ZCJ-0004x4-AE for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:37:27 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L2ZCH-0004vH-6r for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:37:26 -0500 Received: from [199.232.76.173] (port=36015 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L2ZCG-0004vC-V4 for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:37:25 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:53673) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L2Z0N-0003Sf-Uh for qemu-devel@nongnu.org; Tue, 18 Nov 2008 17:25:08 -0500 Received: from smtp07.web.de (fmsmtp07.dlan.cinetic.de [172.20.5.215]) by fmmailgate03.web.de (Postfix) with ESMTP id D54BAF48C682 for ; Tue, 18 Nov 2008 23:24:58 +0100 (CET) Received: from [88.64.11.56] (helo=[192.168.1.198]) by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1L2Z0E-0000qS-00 for qemu-devel@nongnu.org; Tue, 18 Nov 2008 23:24:58 +0100 Message-ID: <49234089.1050901@web.de> Date: Tue, 18 Nov 2008 23:24:09 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <20081117161857.26880.45423.stgit@mchn012c.ww002.siemens.net> <20081117161858.26880.37073.stgit@mchn012c.ww002.siemens.net> <49231EAB.1080900@codemonkey.ws> In-Reply-To: <49231EAB.1080900@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig32E0BAD0707A0E76BDA29AC0" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH v5 04/18] Refactor and enhance break/watchpoint API Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig32E0BAD0707A0E76BDA29AC0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Anthony Liguori wrote: > Jan Kiszka wrote: >> This patch prepares the QEMU cpu_watchpoint/breakpoint API to allow th= e >> succeeding enhancements this series comes with. >> >> First of all, it overcomes MAX_BREAKPOINTS/MAX_WATCHPOINTS by switchin= g >> to dynamically allocated data structures that are kept in linked lists= =2E >> This also allows to return a stable reference to the related objects, >> required for later introduced x86 debug register support. >> >> Breakpoints and watchpoints are stored with their full information set= >> and an additional flag field that makes them easily extensible for use= >> beyond pure guest debugging. >> >> Finally, this restructuring lays the foundation for KVM to hook into >> the debugging infrastructure, providing its own services where hardwar= e >> virtualization demands it. Once QEMUAccel is considered for merge, >> those entry point should be included into its abstraction layer so tha= t >> accellerators can hook in even more cleanly. >> >> Signed-off-by: Jan Kiszka >> =20 >=20 > I noticed you use an open coded doubly linked list. Can you submit a > follow-up patch to convert the code to use a TAILQ from sys-queue.h? >=20 WIP. Takes a few changes, so a bit more testing is also required. But this refactoring already uncovered a use-after-release bug in my original patch. Jan --------------enig32E0BAD0707A0E76BDA29AC0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkkjQI0ACgkQniDOoMHTA+lszACfWwOfOwhJ6zNhifpCnbxuUptW UxsAnRWy3/fmciU0tD+zhDYvZlwOm2WM =mBh1 -----END PGP SIGNATURE----- --------------enig32E0BAD0707A0E76BDA29AC0--