Re: [Qemu-devel] [PATCH 2/6] better type checking for vga

[Anthony Liguori <anthony@codemonkey.ws>]

Glauber Costa wrote:
> unsigned long is too bad of a type. Use ram_addr_t instead.
>
> Signed-off-by: Glauber Costa <glommer@redhat.com>
> ---
>  hw/cirrus_vga.c |    4 ++--
>  hw/vga.c        |    2 +-
>  hw/vga_int.h    |    2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
> index af9c9e6..3cdc8e6 100644
> --- a/hw/cirrus_vga.c
> +++ b/hw/cirrus_vga.c
> @@ -3231,7 +3231,7 @@ static void cirrus_init_common(CirrusVGAState * s, int device_id, int is_pci)
>   ***************************************/
>  
>  void isa_cirrus_vga_init(DisplayState *ds, uint8_t *vga_ram_base,
> -                         unsigned long vga_ram_offset, int vga_ram_size)
> +                         ram_addr_t vga_ram_offset, int vga_ram_size)
>  {
>      CirrusVGAState *s;
>  
> @@ -3273,7 +3273,7 @@ static void cirrus_pci_mmio_map(PCIDevice *d, int region_num,
>  }
>  
>  void pci_cirrus_vga_init(PCIBus *bus, DisplayState *ds, uint8_t *vga_ram_base,
> -                         unsigned long vga_ram_offset, int vga_ram_size)
> +                         ram_addr_t vga_ram_offset, int vga_ram_size)
>  {
>      PCICirrusVGAState *d;
>      uint8_t *pci_conf;
> diff --git a/hw/vga.c b/hw/vga.c
> index bd59aae..b44b77d 100644
> --- a/hw/vga.c
> +++ b/hw/vga.c
> @@ -2105,7 +2105,7 @@ static void vga_map(PCIDevice *pci_dev, int region_num,
>  }
>  
>  void vga_common_init(VGAState *s, DisplayState *ds, uint8_t *vga_ram_base,
> -                     unsigned long vga_ram_offset, int vga_ram_size)
> +                     ram_addr_t vga_ram_offset, int vga_ram_size)
>   

You've changed the signature of this function (and others), without 
updating the definition in vga_int.h.  Compile fails.

Regards,

Antony Liguori