From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L2ofQ-0000Su-C3 for qemu-devel@nongnu.org; Wed, 19 Nov 2008 10:08:32 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L2ofP-0000Sg-Sh for qemu-devel@nongnu.org; Wed, 19 Nov 2008 10:08:32 -0500 Received: from [199.232.76.173] (port=55474 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L2ofP-0000Sd-P2 for qemu-devel@nongnu.org; Wed, 19 Nov 2008 10:08:31 -0500 Received: from qb-out-1314.google.com ([72.14.204.171]:33298) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L2ofP-0003b6-CJ for qemu-devel@nongnu.org; Wed, 19 Nov 2008 10:08:31 -0500 Received: by qb-out-1314.google.com with SMTP id e19so3509369qba.8 for ; Wed, 19 Nov 2008 07:08:30 -0800 (PST) Message-ID: <49242BE9.80901@codemonkey.ws> Date: Wed, 19 Nov 2008 09:08:25 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/6] better type checking for vga References: <1227108377-8442-1-git-send-email-glommer@redhat.com> <1227108377-8442-2-git-send-email-glommer@redhat.com> <1227108377-8442-3-git-send-email-glommer@redhat.com> In-Reply-To: <1227108377-8442-3-git-send-email-glommer@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Glauber Costa wrote: > unsigned long is too bad of a type. Use ram_addr_t instead. > > Signed-off-by: Glauber Costa > --- > hw/cirrus_vga.c | 4 ++-- > hw/vga.c | 2 +- > hw/vga_int.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c > index af9c9e6..3cdc8e6 100644 > --- a/hw/cirrus_vga.c > +++ b/hw/cirrus_vga.c > @@ -3231,7 +3231,7 @@ static void cirrus_init_common(CirrusVGAState * s, int device_id, int is_pci) > ***************************************/ > > void isa_cirrus_vga_init(DisplayState *ds, uint8_t *vga_ram_base, > - unsigned long vga_ram_offset, int vga_ram_size) > + ram_addr_t vga_ram_offset, int vga_ram_size) > { > CirrusVGAState *s; > > @@ -3273,7 +3273,7 @@ static void cirrus_pci_mmio_map(PCIDevice *d, int region_num, > } > > void pci_cirrus_vga_init(PCIBus *bus, DisplayState *ds, uint8_t *vga_ram_base, > - unsigned long vga_ram_offset, int vga_ram_size) > + ram_addr_t vga_ram_offset, int vga_ram_size) > { > PCICirrusVGAState *d; > uint8_t *pci_conf; > diff --git a/hw/vga.c b/hw/vga.c > index bd59aae..b44b77d 100644 > --- a/hw/vga.c > +++ b/hw/vga.c > @@ -2105,7 +2105,7 @@ static void vga_map(PCIDevice *pci_dev, int region_num, > } > > void vga_common_init(VGAState *s, DisplayState *ds, uint8_t *vga_ram_base, > - unsigned long vga_ram_offset, int vga_ram_size) > + ram_addr_t vga_ram_offset, int vga_ram_size) > You've changed the signature of this function (and others), without updating the definition in vga_int.h. Compile fails. Regards, Antony Liguori