From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L2rD8-00023a-KR
	for qemu-devel@nongnu.org; Wed, 19 Nov 2008 12:51:30 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L2rD6-00023O-8V
	for qemu-devel@nongnu.org; Wed, 19 Nov 2008 12:51:29 -0500
Received: from [199.232.76.173] (port=58695 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L2rD6-00023L-1Q
	for qemu-devel@nongnu.org; Wed, 19 Nov 2008 12:51:28 -0500
Received: from wf-out-1314.google.com ([209.85.200.170]:19193)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L2rD5-000417-Nk
	for qemu-devel@nongnu.org; Wed, 19 Nov 2008 12:51:27 -0500
Received: by wf-out-1314.google.com with SMTP id 27so56141wfd.4
	for <qemu-devel@nongnu.org>; Wed, 19 Nov 2008 09:51:26 -0800 (PST)
Message-ID: <49245215.2090403@codemonkey.ws>
Date: Wed, 19 Nov 2008 11:51:17 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 5/6] Introduce kvm logging interface.
References: <1227108377-8442-1-git-send-email-glommer@redhat.com>	<1227108377-8442-2-git-send-email-glommer@redhat.com>	<1227108377-8442-3-git-send-email-glommer@redhat.com>	<1227108377-8442-4-git-send-email-glommer@redhat.com>	<1227108377-8442-5-git-send-email-glommer@redhat.com>	<1227108377-8442-6-git-send-email-glommer@redhat.com>	<49242E53.6000802@codemonkey.ws>
	<5d6222a80811190923o1e83d188kfb258a676811d9c5@mail.gmail.com>
In-Reply-To: <5d6222a80811190923o1e83d188kfb258a676811d9c5@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Glauber Costa wrote:
> On Wed, Nov 19, 2008 at 1:18 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
>   
>
> Are you okay with all dprintfs having these info? This is very
> valuable info, so I'd
> like to have it. I  can send a separate patch.
>   

Yes.

>> Note that start and stop are identical except for a different printf().  The
>> call a common helper function.  Why not fold everything into
>> kvm_dirty_pages_log_change() and make that the public interface
>> (kvm_set_log).
>>     
>
> I personally believe kvm_set_log is a very bad interface. It's nicer
> to read "start"
> and "stop" instead, but I can definitely do this internally.
>   

It's not that important to me.  I'm more interested in removing the 
duplicated code.

>> This interface is weird and broken.  If we wanted to use this for live
>> migration, we would end up passing phys_offset=0 but that has a special
>> meaning here.
>>
>> But why are we passing phys_offset at all?  Why can't we do the lookup here?
>>     
> Because, if you remember, the last time I sent a patch _without_ it,
> you complained
> that we can't really trust any translation based on userspace_addr.
>   

But now that we have phys_offset, we know what the phys_offset is of a 
given slot, right?  So can't we just use that?

Regards,

Anthony Liguori