[Qemu-devel] [PATCH 0 of 2] [UPDATE] DisplayState interface change

[Qemu-devel] [PATCH 0 of 2] [UPDATE] DisplayState interface change

[Stefano Stabellini]

Hi all,
this is an update of the "DisplayState interface change" patch.
The main change is introducing a DisplaySurface struct and a PixelFormat
struct following Anthony's suggestion, they are both inspired by SDL.

I must say that now everything looks much better, Anthony was definitely
right about the fact that we make too many assumptions based only on depth.
Introducing these two structures allowed me also to simplify vnc.c, as
you can see in the second patch.

I tested this series with i386 emulation, cirrus vga, vmware vga, curses
and both sdl and vnc (even at the same time ;).

I realize that the first patch is very big, but it is a small as
possible while still being able to compile.
I suggest you to read it on a per file basis, paying attention to the
changes to console.c, console.h, vga.c, vl.c, vnc.c and sdl.c; the rest
are just substitutions.

Cheers,

Stefano

Re: [Qemu-devel] [PATCH 0 of 2] [UPDATE] DisplayState interface change

[Anthony Liguori]

Hi Stefano,

Stefano Stabellini wrote:
> Hi all,
> this is an update of the "DisplayState interface change" patch.
> The main change is introducing a DisplaySurface struct and a PixelFormat
> struct following Anthony's suggestion, they are both inspired by SDL.
>
> I must say that now everything looks much better, Anthony was definitely
> right about the fact that we make too many assumptions based only on depth.
> Introducing these two structures allowed me also to simplify vnc.c, as
> you can see in the second patch.
>
> I tested this series with i386 emulation, cirrus vga, vmware vga, curses
> and both sdl and vnc (even at the same time ;).
>
> I realize that the first patch is very big, but it is a small as
> possible while still being able to compile.
> I suggest you to read it on a per file basis, paying attention to the
> changes to console.c, console.h, vga.c, vl.c, vnc.c and sdl.c; the rest
> are just substitutions.
>   

I really like this new API.  I took a high level look at the code and I 
think there are only some minor things to be cleaned up but I'd rather 
you split up the first patch like I mentioned before pointing those 
things out.

One thing that I think would be helpful is to add a concise document 
describing how to use this new API.  We can even introduce a docs 
directory for this sort of thing (think Documentation/ in Linux).

Regards,

Anthony Liguori

> Cheers,
>
> Stefano
>
>
>
>   

Re: [Qemu-devel] [PATCH 0 of 2] [UPDATE] DisplayState interface change

[Stefano Stabellini]

Anthony Liguori wrote:

> I really like this new API.  I took a high level look at the code and I
> think there are only some minor things to be cleaned up but I'd rather
> you split up the first patch like I mentioned before pointing those
> things out.
> 

That's good to hear.

I'll add some accessors to try to simplify the patch, like you said.

Re: [Qemu-devel] [PATCH 0 of 2] [UPDATE] DisplayState interface change

[Ivan Bogardi]

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

Hello every Qemu-developers.
Excuse me for I am here. I am not a developer. I wanted to write a question
on the  Qemu forum but it is impossible to registrate. I get the message
that the confirmation cod is wrong and I am sure that I fill in exactly the
right letters and numbers. I tried and tried again, a hundred times.  So I
shall vanish from this group as soon as I get an answer* or* I get help to
registrate.  Please...
My question is:  I cannot maximize the Qemu. I have not the Maximize button
and when I click in the Window menu in left corner, the "Maximize" not
highlighted.
I have operating system Linux Ubuntu 10.8 and I look at Windows XP on Qemu.
Greetings
Ivan

2008/11/21 Stefano Stabellini <stefano.stabellini@eu.citrix.com>

> Anthony Liguori wrote:
>
> > I really like this new API.  I took a high level look at the code and I
> > think there are only some minor things to be cleaned up but I'd rather
> > you split up the first patch like I mentioned before pointing those
> > things out.
> >
>
> That's good to hear.
>
> I'll add some accessors to try to simplify the patch, like you said.
>
>
>

[-- Attachment #2: Type: text/html, Size: 1511 bytes --]

Re: [Qemu-devel] [PATCH 0 of 2] [UPDATE] DisplayState interface change

[Stefano Stabellini]

Ivan Bogardi wrote:

> Hello every Qemu-developers.
> Excuse me for I am here. I am not a developer. I wanted to write a
> question on the  Qemu forum but it is impossible to registrate. I get
> the message that the confirmation cod is wrong and I am sure that I fill
> in exactly the right letters and numbers. I tried and tried again, a
> hundred times.  So I shall vanish from this group as soon as I get an
> answer/ or/ I get help to registrate.  Please...
> My question is:  I cannot maximize the Qemu. I have not the Maximize
> button and when I click in the Window menu in left corner, the
> "Maximize" not highlighted. 
> I have operating system Linux Ubuntu 10.8 and I look at Windows XP on Qemu.
> Greetings
> Ivan

Maximize is not implemented (yet).

Re: [Qemu-devel] [PATCH 0 of 2] [UPDATE] DisplayState interface change

[Ivan Bogardi]

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

I see.
 Is there anybody can help me to registrate on Qemu forum? It is something
wrong with he confirmation code.

2008/11/21 Stefano Stabellini <stefano.stabellini@eu.citrix.com>

> Ivan Bogardi wrote:
>
> > Hello every Qemu-developers.
> > Excuse me for I am here. I am not a developer. I wanted to write a
> > question on the  Qemu forum but it is impossible to registrate. I get
> > the message that the confirmation cod is wrong and I am sure that I fill
> > in exactly the right letters and numbers. I tried and tried again, a
> > hundred times.  So I shall vanish from this group as soon as I get an
> > answer/ or/ I get help to registrate.  Please...
> > My question is:  I cannot maximize the Qemu. I have not the Maximize
> > button and when I click in the Window menu in left corner, the
> > "Maximize" not highlighted.
> > I have operating system Linux Ubuntu 10.8 and I look at Windows XP on
> Qemu.
> > Greetings
> > Ivan
>
> Maximize is not implemented (yet).
>
>
>

[-- Attachment #2: Type: text/html, Size: 1395 bytes --]