From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L3Emb-000893-Nb for qemu-devel@nongnu.org; Thu, 20 Nov 2008 14:01:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L3EmZ-00087s-16 for qemu-devel@nongnu.org; Thu, 20 Nov 2008 14:01:39 -0500 Received: from [199.232.76.173] (port=51922 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L3EmY-00087l-O7 for qemu-devel@nongnu.org; Thu, 20 Nov 2008 14:01:38 -0500 Received: from yw-out-1718.google.com ([74.125.46.156]:18443) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L3EmY-0006t4-Bw for qemu-devel@nongnu.org; Thu, 20 Nov 2008 14:01:38 -0500 Received: by yw-out-1718.google.com with SMTP id 6so266542ywa.82 for ; Thu, 20 Nov 2008 11:01:36 -0800 (PST) Message-ID: <4925B40C.8030507@codemonkey.ws> Date: Thu, 20 Nov 2008 13:01:32 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0 of 2] [UPDATE] DisplayState interface change References: <492596E0.6050900@eu.citrix.com> In-Reply-To: <492596E0.6050900@eu.citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi Stefano, Stefano Stabellini wrote: > Hi all, > this is an update of the "DisplayState interface change" patch. > The main change is introducing a DisplaySurface struct and a PixelFormat > struct following Anthony's suggestion, they are both inspired by SDL. > > I must say that now everything looks much better, Anthony was definitely > right about the fact that we make too many assumptions based only on depth. > Introducing these two structures allowed me also to simplify vnc.c, as > you can see in the second patch. > > I tested this series with i386 emulation, cirrus vga, vmware vga, curses > and both sdl and vnc (even at the same time ;). > > I realize that the first patch is very big, but it is a small as > possible while still being able to compile. > I suggest you to read it on a per file basis, paying attention to the > changes to console.c, console.h, vga.c, vl.c, vnc.c and sdl.c; the rest > are just substitutions. > I really like this new API. I took a high level look at the code and I think there are only some minor things to be cleaned up but I'd rather you split up the first patch like I mentioned before pointing those things out. One thing that I think would be helpful is to add a concise document describing how to use this new API. We can even introduce a docs directory for this sort of thing (think Documentation/ in Linux). Regards, Anthony Liguori > Cheers, > > Stefano > > > >