From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L4eL5-00083N-GK
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 11:31:07 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L4eL3-00082N-O6
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 11:31:07 -0500
Received: from [199.232.76.173] (port=34003 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L4eL3-00082D-Im
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 11:31:05 -0500
Received: from an-out-0708.google.com ([209.85.132.249]:45917)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L4eL3-0006Y3-6b
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 11:31:05 -0500
Received: by an-out-0708.google.com with SMTP id c38so781035ana.37
	for <qemu-devel@nongnu.org>; Mon, 24 Nov 2008 08:31:03 -0800 (PST)
Message-ID: <492AD6C4.90001@codemonkey.ws>
Date: Mon, 24 Nov 2008 10:31:00 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/5] Remove tabs from qcow_aio_read_cb().
	Fix indentation.
References: <20081123145248.22178.36228.stgit@dhcp-1-237.tlv.redhat.com>
	<20081123145257.22178.1698.stgit@dhcp-1-237.tlv.redhat.com>
In-Reply-To: <20081123145257.22178.1698.stgit@dhcp-1-237.tlv.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
>
>  block-qcow2.c |   78 +++++++++++++++++++++++++++++----------------------------
>  1 files changed, 39 insertions(+), 39 deletions(-)
>
> diff --git a/block-qcow2.c b/block-qcow2.c
> index dc73769..ab19a4e 100644
> --- a/block-qcow2.c
> +++ b/block-qcow2.c
> @@ -1186,7 +1186,7 @@ static void qcow_aio_read_cb(void *opaque, int ret)
>  
>      acb->hd_aiocb = NULL;
>      if (ret < 0) {
> -    fail:
> +fail:
>          acb->common.cb(acb->common.opaque, ret);
>          qemu_aio_release(acb);
>          return;
> @@ -1200,8 +1200,8 @@ static void qcow_aio_read_cb(void *opaque, int ret)
>      } else {
>          if (s->crypt_method) {
>              encrypt_sectors(s, acb->sector_num, acb->buf, acb->buf,
> -                            acb->n, 0,
> -                            &s->aes_decrypt_key);
> +                    acb->n, 0,
> +                    &s->aes_decrypt_key);
>   

Why did you change this indenting?  There is no tabs and I think it's 
better the way it is than how you made it.

> @@ -1551,7 +1551,7 @@ static int qcow_make_empty(BlockDriverState *bs)
>  
>      memset(s->l1_table, 0, l1_length);
>      if (bdrv_pwrite(s->hd, s->l1_table_offset, s->l1_table, l1_length) < 0)
> -	return -1;
> +    return -1;
>      ret = bdrv_truncate(s->hd, s->l1_table_offset + l1_length);
>      if (ret < 0)
>          return ret;
>   

That's really not right.

Regards,

Anthony Liguori

>
>