From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L4eMt-0000vt-7P
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 11:32:59 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L4eMr-0000td-Ap
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 11:32:58 -0500
Received: from [199.232.76.173] (port=54475 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L4eMr-0000tS-0Z
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 11:32:57 -0500
Received: from an-out-0708.google.com ([209.85.132.244]:49382)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L4eMq-0006oH-Lk
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 11:32:56 -0500
Received: by an-out-0708.google.com with SMTP id c38so781568ana.37
	for <qemu-devel@nongnu.org>; Mon, 24 Nov 2008 08:32:56 -0800 (PST)
Message-ID: <492AD735.7030708@codemonkey.ws>
Date: Mon, 24 Nov 2008 10:32:53 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/5] Introduce new helper function
	qcow_shedule_bh().
References: <20081123145248.22178.36228.stgit@dhcp-1-237.tlv.redhat.com>
	<20081123145304.22178.27216.stgit@dhcp-1-237.tlv.redhat.com>
In-Reply-To: <20081123145304.22178.27216.stgit@dhcp-1-237.tlv.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Gleb Natapov wrote:
> Use it to remove code duplications from qcow_aio_read_cb().
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
>
>  block-qcow2.c |   44 +++++++++++++++++---------------------------
>  1 files changed, 17 insertions(+), 27 deletions(-)
>
> diff --git a/block-qcow2.c b/block-qcow2.c
> index ab19a4e..69f6414 100644
> --- a/block-qcow2.c
> +++ b/block-qcow2.c
> @@ -1177,6 +1177,20 @@ static void qcow_aio_read_bh(void *opaque)
>      qcow_aio_read_cb(opaque, 0);
>  }
>  
> +static int qcow_shedule_bh(QEMUBHFunc *cb, QCowAIOCB *acb)
> +{
> +    if (acb->bh)
> +        return -EIO;
> +
> +    acb->bh = qemu_bh_new(cb, acb);
> +    if (!acb->bh)
> +        return -EIO;
> +
> +    qemu_bh_schedule(acb->bh);
> +
> +    return 0;
> +}
> +
>  static void qcow_aio_read_cb(void *opaque, int ret)
>  {
>      QCowAIOCB *acb = opaque;
> @@ -1232,30 +1246,14 @@ fail:
>                  if (acb->hd_aiocb == NULL)
>                      goto fail;
>              } else {
> -                if (acb->bh) {
> -                    ret = -EIO;
> -                    goto fail;
> -                }
> -                acb->bh = qemu_bh_new(qcow_aio_read_bh, acb);
> -                if (!acb->bh) {
> -                    ret = -EIO;
> +                if((ret = qcow_shedule_bh(qcow_aio_read_bh, acb)) < 0)
>   

Please do this on two lines and watch the whitespace damage.  Also, you 
have a consistent typo in "schedule".

Regards,

Anthony Liguori