From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L4eau-0005bs-Ro for qemu-devel@nongnu.org; Mon, 24 Nov 2008 11:47:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L4eat-0005b9-87 for qemu-devel@nongnu.org; Mon, 24 Nov 2008 11:47:28 -0500 Received: from [199.232.76.173] (port=56164 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4eas-0005b1-Ru for qemu-devel@nongnu.org; Mon, 24 Nov 2008 11:47:26 -0500 Received: from smtp.eu.citrix.com ([62.200.22.115]:58570) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L4eas-0000o0-Cx for qemu-devel@nongnu.org; Mon, 24 Nov 2008 11:47:26 -0500 Message-ID: <492ADB80.9070309@eu.citrix.com> Date: Mon, 24 Nov 2008 16:51:12 +0000 From: Stefano Stabellini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 4 of 5] [UPDATE] DisplayState interface change References: <4926EB0B.6040007@eu.citrix.com> <492864CB.3060905@codemonkey.ws> In-Reply-To: <492864CB.3060905@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: > I think we need another intermediate step here. > > Right now, we have a pretty poor abstraction wrt QEMUConsole and > DisplayState. QEMUConsole is known to much of the hardware emulation > but DisplayState is too. > > I think we need a step that replaces all notions of QEMUConsole in > hw/*.c with DisplayState including an appropriate creation functions. > There's really no point in passing a DisplayState to the hardware > devices, instead they should be allocating it and returning it to be > passed to the SDL/VNC front-ends. > If am not mistaken this is exactly what Paul proposed. As I said before, this model is certainly more elegant, but presents some hidden issues: what do we do with the text consoles? Right now a single DisplayState is shared between a graphic console and multiple text console. Do we really want to allocate a buffer each? Who is going to do the console multiplexing? Even though the QEMUConsole abstraction is not very elegant and should probably be improved I believe it is a different and independent issue from the one addressed in this series.