From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L4haM-0005ba-M1 for qemu-devel@nongnu.org; Mon, 24 Nov 2008 14:59:06 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L4haK-0005aW-OG for qemu-devel@nongnu.org; Mon, 24 Nov 2008 14:59:06 -0500 Received: from [199.232.76.173] (port=51663 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4haK-0005aO-K7 for qemu-devel@nongnu.org; Mon, 24 Nov 2008 14:59:04 -0500 Received: from yw-out-1718.google.com ([74.125.46.156]:25502) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L4haH-0006h7-Sw for qemu-devel@nongnu.org; Mon, 24 Nov 2008 14:59:02 -0500 Received: by yw-out-1718.google.com with SMTP id 6so854202ywa.82 for ; Mon, 24 Nov 2008 11:59:00 -0800 (PST) Message-ID: <492B0781.6050505@codemonkey.ws> Date: Mon, 24 Nov 2008 13:58:57 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 4 of 5] [UPDATE] DisplayState interface change References: <4926EB0B.6040007@eu.citrix.com> <492864CB.3060905@codemonkey.ws> <492ADB80.9070309@eu.citrix.com> In-Reply-To: <492ADB80.9070309@eu.citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stefano Stabellini wrote: > Anthony Liguori wrote: > > > > If am not mistaken this is exactly what Paul proposed. > As I said before, this model is certainly more elegant, but presents > some hidden issues: > > what do we do with the text consoles? > Right now a single DisplayState is shared between a graphic console and > multiple text console. > Do we really want to allocate a buffer each? > Who is going to do the console multiplexing? > We really should have a DisplayState that multiplexes multiple DisplayStates. TextConsole should just provide a DisplayState that can be multiplexed. > Even though the QEMUConsole abstraction is not very elegant and should > probably be improved I believe it is a different and independent issue > from the one addressed in this series. > I'm not asking you to do that refactoring. But since we all pretty much agree that this is how things should look, I want to make sure that the DisplayState API takes all of this into account. So in that vein, I'd like to see all the things that call graphic_console_init changed to not take a DisplayState, but rather to have graphic_console_init() return an allocated DisplayState. These functions should then return a DisplayState which can be passed to VNC/SDL. From what I can tell, this is not a huge change. You shouldn't have to really touch any of the console code. I think this is important to sure up what the DisplayState API looks like and how the rest of QEMU interacts with it. If this seems like a major refactoring, let me know and either you're misunderstanding what I'm suggesting or I've miscalculated how much change is required here :-) Regards, Anthony Liguori