From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L4wt3-0001Ju-1M for qemu-devel@nongnu.org; Tue, 25 Nov 2008 07:19:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L4wt1-0001IE-0c for qemu-devel@nongnu.org; Tue, 25 Nov 2008 07:19:24 -0500 Received: from [199.232.76.173] (port=45438 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4wt0-0001Hn-QT for qemu-devel@nongnu.org; Tue, 25 Nov 2008 07:19:22 -0500 Received: from smtp.eu.citrix.com ([62.200.22.115]:42857) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L4wt0-0001Yo-MR for qemu-devel@nongnu.org; Tue, 25 Nov 2008 07:19:22 -0500 Message-ID: <492BEE32.6020209@eu.citrix.com> Date: Tue, 25 Nov 2008 12:23:14 +0000 From: Stefano Stabellini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 4 of 5] [UPDATE] DisplayState interface change References: <4926EB0B.6040007@eu.citrix.com> <492864CB.3060905@codemonkey.ws> <492ADB80.9070309@eu.citrix.com> <492B0781.6050505@codemonkey.ws> In-Reply-To: <492B0781.6050505@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: > I'm not asking you to do that refactoring. But since we all pretty much > agree that this is how things should look, I want to make sure that the > DisplayState API takes all of this into account. > > So in that vein, I'd like to see all the things that call > graphic_console_init changed to not take a DisplayState, but rather to > have graphic_console_init() return an allocated DisplayState. These > functions should then return a DisplayState which can be passed to VNC/SDL. > > From what I can tell, this is not a huge change. You shouldn't have to > really touch any of the console code. I think this is important to sure > up what the DisplayState API looks like and how the rest of QEMU > interacts with it. > > If this seems like a major refactoring, let me know and either you're > misunderstanding what I'm suggesting or I've miscalculated how much > change is required here :-) That's fine, it is a simple change, it was me that didn't understand correctly what you were suggesting. Since at the moment we don't have a DisplayState multiplexing function, this means that we are going to keep the text_console_init as it is now so that we can still the serial and the monitor interfaces, right?