From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L5cuS-0004iD-Jg
	for qemu-devel@nongnu.org; Thu, 27 Nov 2008 04:11:40 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L5cuR-0004g3-GH
	for qemu-devel@nongnu.org; Thu, 27 Nov 2008 04:11:39 -0500
Received: from [199.232.76.173] (port=49049 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L5cuR-0004fu-Ah
	for qemu-devel@nongnu.org; Thu, 27 Nov 2008 04:11:39 -0500
Received: from mx2.redhat.com ([66.187.237.31]:44131)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1L5cuQ-0003cB-3s
	for qemu-devel@nongnu.org; Thu, 27 Nov 2008 04:11:38 -0500
Message-ID: <492E643A.90604@redhat.com>
Date: Thu, 27 Nov 2008 10:11:22 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/3] sockets: switch vnc to new code, support
	vnc port auto-allocation.
References: <1225730550-31941-1-git-send-email-kraxel@redhat.com>
	<1225730550-31941-3-git-send-email-kraxel@redhat.com>
	<20081126232517.GQ31893@us.ibm.com>
In-Reply-To: <20081126232517.GQ31893@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: qemu-devel@nongnu.org

Ryan Harper wrote:
> * Gerd Hoffmann <kraxel@redhat.com> [2008-11-03 10:57]:
> When using an existing unix file like:
> 
> -vnc unix:/tmp/file1Y2nY2
> 
> qemu fails to bind a unix socket because the vnc call to unix_listen
> includes the unix: prefix, and stores that in the unix.sun_path.

Oops.

> Haven't tested all cases of -vnc, so, double check that this is the
> right fix.

Yep, fix is fine.

thanks,
  Gerd