From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L5q33-00049B-GW for qemu-devel@nongnu.org; Thu, 27 Nov 2008 18:13:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L5q2z-00048F-T1 for qemu-devel@nongnu.org; Thu, 27 Nov 2008 18:13:25 -0500 Received: from [199.232.76.173] (port=42859 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L5q2z-00048C-PE for qemu-devel@nongnu.org; Thu, 27 Nov 2008 18:13:21 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:43177) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L5q2y-0005o8-Oo for qemu-devel@nongnu.org; Thu, 27 Nov 2008 18:13:21 -0500 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate03.web.de (Postfix) with ESMTP id 7AF86F4E2E7F for ; Fri, 28 Nov 2008 00:13:14 +0100 (CET) Received: from [88.64.25.231] (helo=[192.168.1.198]) by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1L5q2s-00015D-00 for qemu-devel@nongnu.org; Fri, 28 Nov 2008 00:13:14 +0100 Message-ID: <492F2984.9050806@web.de> Date: Fri, 28 Nov 2008 00:13:08 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <200811272230.12559.frank.mehnert@sun.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig2630D18348083DFAFBBFF548" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: typo in target-i386/ops_sse.h Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2630D18348083DFAFBBFF548 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable andrzej zaborowski wrote: > Hi, >=20 > 2008/11/27 Frank Mehnert : >> I believe there is a typo in target-i386/ops_sse.h in the macro >> SSE_HELPER_F: >=20 > Ooops, you're right about the typo, but I think it should something lik= e this: > --- a/target-i386/ops_sse.h > +++ b/target-i386/ops_sse.h > @@ -1499,12 +1499,12 @@ void glue(name, SUFFIX) (Reg *d, Reg *s)\ > {\ > d->elem(0) =3D F(0);\ > d->elem(1) =3D F(1);\ > - d->elem(2) =3D F(2);\ > - d->elem(3) =3D F(3);\ > - if (num > 3) {\ > - d->elem(4) =3D F(4);\ > - d->elem(5) =3D F(5);\ > - if (num > 5) {\ > + if (num > 2) {\ > + d->elem(2) =3D F(2);\ > + d->elem(3) =3D F(3);\ > + if (num > 4) {\ > + d->elem(4) =3D F(4);\ > + d->elem(5) =3D F(5);\ > d->elem(6) =3D F(6);\ > d->elem(7) =3D F(7);\ > }\ >=20 > I'm not sure why this didn't generate warnings. It does - with gcc4 (array subscript is above array bounds). I saw them in kvm-userspace, but there were so many (a lot likely due to non-upstream stuff) that I ignored them for now. Now your patch just removed 8 upstream warnings. But is this stuff already in use? Should cause subtle guest state corruptions if actually executed. That reminds me that we should have a "zero new warnings policy" for changes. But reality still looks different... Jan --------------enig2630D18348083DFAFBBFF548 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkkvKYkACgkQniDOoMHTA+k6KgCbB37u29ETNC8Cis1itDHH87lO //UAnRRMpVlpa8q1Hbe667CC/c7P92ki =SuVT -----END PGP SIGNATURE----- --------------enig2630D18348083DFAFBBFF548--