From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L5qVX-0006JA-V5
	for qemu-devel@nongnu.org; Thu, 27 Nov 2008 18:42:52 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L5qVX-0006Ik-1O
	for qemu-devel@nongnu.org; Thu, 27 Nov 2008 18:42:51 -0500
Received: from [199.232.76.173] (port=50447 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L5qVW-0006Ic-PS
	for qemu-devel@nongnu.org; Thu, 27 Nov 2008 18:42:50 -0500
Received: from an-out-0708.google.com ([209.85.132.248]:29339)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L5qVW-0000xd-Di
	for qemu-devel@nongnu.org; Thu, 27 Nov 2008 18:42:50 -0500
Received: by an-out-0708.google.com with SMTP id c38so429174ana.37
	for <qemu-devel@nongnu.org>; Thu, 27 Nov 2008 15:42:48 -0800 (PST)
Message-ID: <492F3074.6060200@codemonkey.ws>
Date: Thu, 27 Nov 2008 17:42:44 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0 of 7] [UPDATE] DisplayState interface change
References: <492D8B94.4000805@eu.citrix.com>	<200811261840.22618.paul@codesourcery.com>
	<492D9EA4.9050008@eu.citrix.com>
In-Reply-To: <492D9EA4.9050008@eu.citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Paul Brook <paul@codesourcery.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Stefano Stabellini wrote:
> Paul Brook wrote:
>
>   
>
>>> - do not use is_active_console, use is_graphic_console instead.
>>>       
>> This is wrong. There may be multiple graphic consoles.
>>     
>
> I thought we wanted to move to a model in which a DisplayState
> corresponds to a single QEMUConsole and a single graphic device.
> This is the reason for Anthony to ask me this update, if I am not mistaken.
>   

I need to look more closely at the patches (and I will tomorrow), but to 
me, the use of is_active_console or is_graphics_console is a red 
herring.  Nothing should never need to know whether it's the "active" 
console.  Such a concept simply shouldn't exist.

I think this is Paul's point about multiple graphics consoles.  If you 
have two graphics consoles, than the concept of active console doesn't 
make very much sense.  Is that what you were thinking Paul?

>>> This patch changes the graphical_console_init function to return an
>>> allocated DisplayState instead of a QEMUConsole.
>>>       
>> You should also remove QEMUConsole.
>>     
>
> I removed QEMUConsole from the graphic devices, I am not going to
> completely get rid of it because it is currently needed by text consoles
> and to multiplex multiple consoles.
>   

QEMUConsole is just a typedef right now.  Could you remove the typedef?  
It should become unused after your patch.

Regards,

Anthony Liguori