From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L614b-0003V7-9V for qemu-devel@nongnu.org; Fri, 28 Nov 2008 05:59:45 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L614T-0003RT-U9 for qemu-devel@nongnu.org; Fri, 28 Nov 2008 05:59:42 -0500 Received: from [199.232.76.173] (port=57901 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L614T-0003RH-I8 for qemu-devel@nongnu.org; Fri, 28 Nov 2008 05:59:37 -0500 Received: from smtp.eu.citrix.com ([62.200.22.115]:6360) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L614S-00005K-EV for qemu-devel@nongnu.org; Fri, 28 Nov 2008 05:59:37 -0500 Message-ID: <492FD001.7060504@eu.citrix.com> Date: Fri, 28 Nov 2008 11:03:29 +0000 From: Stefano Stabellini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0 of 7] [UPDATE] DisplayState interface change References: <492D8B94.4000805@eu.citrix.com> <200811261840.22618.paul@codesourcery.com> <492D9EA4.9050008@eu.citrix.com> <492F3074.6060200@codemonkey.ws> In-Reply-To: <492F3074.6060200@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Paul Brook Anthony Liguori wrote: > Stefano Stabellini wrote: >> Paul Brook wrote: >> >> >>>> - do not use is_active_console, use is_graphic_console instead. >>>> >>> This is wrong. There may be multiple graphic consoles. >>> >> >> I thought we wanted to move to a model in which a DisplayState >> corresponds to a single QEMUConsole and a single graphic device. >> This is the reason for Anthony to ask me this update, if I am not >> mistaken. >> > > I need to look more closely at the patches (and I will tomorrow), but to > me, the use of is_active_console or is_graphics_console is a red > herring. Nothing should never need to know whether it's the "active" > console. Such a concept simply shouldn't exist. > > I think this is Paul's point about multiple graphics consoles. If you > have two graphics consoles, than the concept of active console doesn't > make very much sense. Is that what you were thinking Paul? I can easily remove it, at the price of changing qemu_console_resize in: void qemu_console_resize(DisplayState *ds, int width, int height, int bpp, int linesize, uint8_t *data); >>>> This patch changes the graphical_console_init function to return an >>>> allocated DisplayState instead of a QEMUConsole. >>>> >>> You should also remove QEMUConsole. >>> >> >> I removed QEMUConsole from the graphic devices, I am not going to >> completely get rid of it because it is currently needed by text consoles >> and to multiplex multiple consoles. >> > > QEMUConsole is just a typedef right now. Could you remove the typedef? > It should become unused after your patch. > I think I could remove it now, without even a single compile warning :)