From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L61ND-0002sg-Ur for qemu-devel@nongnu.org; Fri, 28 Nov 2008 06:18:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L61NC-0002sC-TH for qemu-devel@nongnu.org; Fri, 28 Nov 2008 06:18:59 -0500 Received: from [199.232.76.173] (port=40854 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L61NC-0002rr-Lw for qemu-devel@nongnu.org; Fri, 28 Nov 2008 06:18:58 -0500 Received: from hall.aurel32.net ([88.191.82.174]:43868) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L61NC-00037P-C1 for qemu-devel@nongnu.org; Fri, 28 Nov 2008 06:18:58 -0500 Received: from anguille.univ-lyon1.fr ([134.214.4.207]) by hall.aurel32.net with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1L61N5-0001cb-I4 for qemu-devel@nongnu.org; Fri, 28 Nov 2008 12:18:51 +0100 Message-ID: <492FD396.8090806@aurel32.net> Date: Fri, 28 Nov 2008 12:18:46 +0100 From: Aurelien Jarno MIME-Version: 1.0 Subject: Re: [Qemu-devel] [5806] qemu-doc.texi: document downscript network option References: <20081128102659.GA6138@shareable.org> In-Reply-To: <20081128102659.GA6138@shareable.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Jamie Lokier a écrit : > Aurelien Jarno wrote a patch, resulting in: >> @item -net tap[,vlan=@var{n}][,fd=@var{h}][,ifname=@var{name}][,script=@var{file}][,downscript=@var{dfile}] >> Connect the host TAP network interface @var{name} to VLAN @var{n} >> and use the network script @var{file} to configure it. The default >> network script is @file{/etc/qemu-ifup}. Use @option{script=no} to >> disable script execution. If @var{name} is not provided, the OS >> automatically provides one. Use network script @var{dfile} to >> deconfigure the interface. Use @option{downscript=no} to disable >> script execution. @option{fd}=@var{h} can be used to specify the >> handle of an already opened host TAP interface. > > Two things don't make sense: > > 1. Do you have to write "downscript=no" to disable > downscript execution? If you don't need it, that part of the > documentation is unnecessary. If you do need it, then it's not > backward-compatible with earlier QEMU versions. > > > 2. If you do need "downscript=no" to disable it, what's > the default downscript name if you don't have "downscript=no"? > By default it uses /etc/qemu-ifdown. You have to set downscript=no to disabled that. Note that the code hasn't changed, so there is no worry about backward compatiblity. This behaviour is already present in qemu 0.9.1 (and probably in previous versions). It is only undocumented. > Also, it would be better for the text to describe the options in the > same order as the synopsis in the first line, especially describing > the two script options without anything else between. > All that should be fixed in revision r5807. -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net