From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L6jEc-0000xS-FC for qemu-devel@nongnu.org; Sun, 30 Nov 2008 05:09:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L6jEZ-0000tI-CK for qemu-devel@nongnu.org; Sun, 30 Nov 2008 05:09:01 -0500 Received: from [199.232.76.173] (port=39484 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L6jEZ-0000t7-6m for qemu-devel@nongnu.org; Sun, 30 Nov 2008 05:08:59 -0500 Received: from mx2.redhat.com ([66.187.237.31]:42552) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L6jEY-0002W0-NW for qemu-devel@nongnu.org; Sun, 30 Nov 2008 05:08:58 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAUA8rwA024676 for ; Sun, 30 Nov 2008 05:08:55 -0500 Message-ID: <49326633.9020007@redhat.com> Date: Sun, 30 Nov 2008 12:08:51 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute References: <492FDA5D.6080602@siemens.com> <493030EA.4040405@web.de> In-Reply-To: <493030EA.4040405@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Jan Kiszka wrote: >> Breaking the standard is what brings us the joys of recently (re)posted >> patch for NetBSD and [u]intXX fun. >> > > I have no problem with calling it 'noreturn' instead. > That will break code that wants to use 'noreturn' as a local variable. I think ATTR_NORETURN, while a lot uglier, is safer. -- error compiling committee.c: too many arguments to function