From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L6lV4-0007Yh-Ik for qemu-devel@nongnu.org; Sun, 30 Nov 2008 07:34:10 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L6lV3-0007Xn-5C for qemu-devel@nongnu.org; Sun, 30 Nov 2008 07:34:10 -0500 Received: from [199.232.76.173] (port=33787 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L6lV3-0007Xe-0s for qemu-devel@nongnu.org; Sun, 30 Nov 2008 07:34:09 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:54608) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L6lV2-0005ex-LK for qemu-devel@nongnu.org; Sun, 30 Nov 2008 07:34:08 -0500 Received: from smtp07.web.de (fmsmtp07.dlan.cinetic.de [172.20.5.215]) by fmmailgate02.web.de (Postfix) with ESMTP id 324CBF739898 for ; Sun, 30 Nov 2008 13:34:00 +0100 (CET) Received: from [88.65.243.230] (helo=[192.168.1.198]) by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1L6lUt-0006Qh-00 for qemu-devel@nongnu.org; Sun, 30 Nov 2008 13:33:59 +0100 Message-ID: <49328833.3000605@web.de> Date: Sun, 30 Nov 2008 13:33:55 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <492FDA5D.6080602@siemens.com> <493030EA.4040405@web.de> <49326633.9020007@redhat.com> In-Reply-To: <49326633.9020007@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4F7BDE0EC28E119020CE51F2" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4F7BDE0EC28E119020CE51F2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > Jan Kiszka wrote: >>> Breaking the standard is what brings us the joys of recently (re)post= ed >>> patch for NetBSD and [u]intXX fun. >>> =20 >> >> I have no problem with calling it 'noreturn' instead. >> =20 >=20 > That will break code that wants to use 'noreturn' as a local variable. = > I think ATTR_NORETURN, while a lot uglier, is safer. Do you have such code already? Is it exported beyond qemu scope? Then why not going for our own convention "'noreturn' is reserved as function attribute"? (And yes, your macro is ugly :) ). Jan --------------enig4F7BDE0EC28E119020CE51F2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkkyiDYACgkQniDOoMHTA+kJFQCePtKGzyvK9+tNDZhfmapWSNLY HjYAn0eSenpOWTbh2zwfeOEKmQFU5lbR =ULI1 -----END PGP SIGNATURE----- --------------enig4F7BDE0EC28E119020CE51F2--