[Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

Laurent Desnogues wrote:
> On Sun, Nov 30, 2008 at 12:51 PM, Stefan Weil <berlios@weilnetz.de> wrote:
>> Why do we need a new macro instead of just using __attribute__
>> ((__noreturn__))?
> 
> Don't we need it to prevent gcc-ism from being all over the code?

Yep, and that's also why we need wrapping. You can easily define it away
if your compiler doesn't support it. We just need to add the required
conditions.

> Though I wonder how much tcg converted code still depends on
> being compiled by gcc.

I guess once the hard dependencies are removed, fixing things like the
existing __attributes__ etc. will just be mechanical work.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]