From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L6lZF-0008Sk-Qv for qemu-devel@nongnu.org; Sun, 30 Nov 2008 07:38:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L6lZE-0008SK-0R for qemu-devel@nongnu.org; Sun, 30 Nov 2008 07:38:29 -0500 Received: from [199.232.76.173] (port=53227 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L6lZD-0008SH-NX for qemu-devel@nongnu.org; Sun, 30 Nov 2008 07:38:27 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:48006) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L6lZD-0006yF-5e for qemu-devel@nongnu.org; Sun, 30 Nov 2008 07:38:27 -0500 Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172]) by fmmailgate03.web.de (Postfix) with ESMTP id 2607DF4FA7C0 for ; Sun, 30 Nov 2008 13:38:26 +0100 (CET) Received: from [88.65.243.230] (helo=[192.168.1.198]) by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1L6lZC-00083i-00 for qemu-devel@nongnu.org; Sun, 30 Nov 2008 13:38:26 +0100 Message-ID: <49328941.9050908@web.de> Date: Sun, 30 Nov 2008 13:38:25 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <492FDA5D.6080602@siemens.com> <493030EA.4040405@web.de> <49326633.9020007@redhat.com> <49327E37.6050003@weilnetz.de> <761ea48b0811300400l6edcc1f6g63261dd8b4629574@mail.gmail.com> In-Reply-To: <761ea48b0811300400l6edcc1f6g63261dd8b4629574@mail.gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig1D50DFF901D65320E4696152" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1D50DFF901D65320E4696152 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Laurent Desnogues wrote: > On Sun, Nov 30, 2008 at 12:51 PM, Stefan Weil wro= te: >> Why do we need a new macro instead of just using __attribute__ >> ((__noreturn__))? >=20 > Don't we need it to prevent gcc-ism from being all over the code? Yep, and that's also why we need wrapping. You can easily define it away if your compiler doesn't support it. We just need to add the required conditions. > Though I wonder how much tcg converted code still depends on > being compiled by gcc. I guess once the hard dependencies are removed, fixing things like the existing __attributes__ etc. will just be mechanical work. Jan --------------enig1D50DFF901D65320E4696152 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkkyiUEACgkQniDOoMHTA+lovwCggPTHQi6UUvmkMamsoB7dGq7n 2kMAn2ydtsmZYTbuL4Y0SzUWJpeVIVfI =8uRW -----END PGP SIGNATURE----- --------------enig1D50DFF901D65320E4696152--