From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L6lmf-0007zE-La
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 07:52:21 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L6lmd-0007xt-PL
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 07:52:20 -0500
Received: from [199.232.76.173] (port=52644 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L6lmd-0007xg-Ed
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 07:52:19 -0500
Received: from moutng.kundenserver.de ([212.227.126.187]:64470)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1L6lmc-0002kn-Q4
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 07:52:19 -0500
Received: from localhost ([127.0.0.1] ident=stefan)
	by flocke.weilnetz.de with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1L6lmZ-0001s6-O7
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 13:52:15 +0100
Message-ID: <49328C7F.1050705@mail.berlios.de>
Date: Sun, 30 Nov 2008 13:52:15 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute
References: <492FDA5D.6080602@siemens.com>	<Pine.LNX.4.64.0811282031360.2200@linmac.oyster.ru>	<493030EA.4040405@web.de>	<49326633.9020007@redhat.com>	<49327E37.6050003@weilnetz.de>	<761ea48b0811300400l6edcc1f6g63261dd8b4629574@mail.gmail.com>
	<49328941.9050908@web.de>
In-Reply-To: <49328941.9050908@web.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Jan Kiszka schrieb:
> Laurent Desnogues wrote:
>> On Sun, Nov 30, 2008 at 12:51 PM, Stefan Weil <berlios@weilnetz.de>
>> wrote:
>>> Why do we need a new macro instead of just using __attribute__
>>> ((__noreturn__))?
>> Don't we need it to prevent gcc-ism from being all over the code?
>
> Yep, and that's also why we need wrapping. You can easily define it away
> if your compiler doesn't support it. We just need to add the required
> conditions.
>
>> Though I wonder how much tcg converted code still depends on
>> being compiled by gcc.
>
> I guess once the hard dependencies are removed, fixing things like the
> existing __attributes__ etc. will just be mechanical work.
>
> Jan
>


For compilers which don't support __attributes__, a simple

#define __attributes__(dummy) /* dummy */

or an equivalent command line option would eliminate all gcc-isms.
I don't think we need wrapping, at least not now.

Stefan