From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L6nPM-0007XA-0B for qemu-devel@nongnu.org; Sun, 30 Nov 2008 09:36:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L6nPK-0007Ui-Et for qemu-devel@nongnu.org; Sun, 30 Nov 2008 09:36:23 -0500 Received: from [199.232.76.173] (port=44434 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L6nPK-0007UX-BS for qemu-devel@nongnu.org; Sun, 30 Nov 2008 09:36:22 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:34098) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L6nPJ-0003Tx-KD for qemu-devel@nongnu.org; Sun, 30 Nov 2008 09:36:22 -0500 Message-ID: <4932A4D9.2070106@web.de> Date: Sun, 30 Nov 2008 15:36:09 +0100 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute References: <492FDA5D.6080602@siemens.com> <493030EA.4040405@web.de> <49326633.9020007@redhat.com> <49328833.3000605@web.de> <20081130131107.GA28482@networkno.de> In-Reply-To: <20081130131107.GA28482@networkno.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig38A5D2C6B662E684B3D91E1C" Sender: jan.kiszka@web.de Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thiemo Seufer Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig38A5D2C6B662E684B3D91E1C Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thiemo Seufer wrote: > Jan Kiszka wrote: >> Avi Kivity wrote: >>> Jan Kiszka wrote: >>>>> Breaking the standard is what brings us the joys of recently (re)po= sted >>>>> patch for NetBSD and [u]intXX fun. >>>>> =20 >>>> I have no problem with calling it 'noreturn' instead. >>>> =20 >>> That will break code that wants to use 'noreturn' as a local variable= =2E=20 >>> I think ATTR_NORETURN, while a lot uglier, is safer. >> Do you have such code already? Is it exported beyond qemu scope? Then >> why not going for our own convention "'noreturn' is reserved as functi= on >> attribute"? (And yes, your macro is ugly :) ). >=20 > "Macro names should be in upper case" is also a useful convention. Generally yes. But there are exceptions when the macro is used in a context where upper case disturbs the readability instead of improving it. I would argue that this is the case here, but it's always a matter of taste. >=20 > FWIW, I agree with Stefan, there's currently not much need to isolate > gcc-isms. If everyone prefers having __attribute__ in the function prototypes directly -- OK. All I want is to get rid of the warnings without changing the code into the wrong direction. Jan --------------enig38A5D2C6B662E684B3D91E1C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkkypOEACgkQniDOoMHTA+mXAwCeLlMOqYL7eL4CR11mZ/GpzrrM 0nIAn2PT3tJZ9WfBCQSd5hd35gAwplWi =VuYk -----END PGP SIGNATURE----- --------------enig38A5D2C6B662E684B3D91E1C--