From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L7FGC-0002SM-SL for qemu-devel@nongnu.org; Mon, 01 Dec 2008 15:20:48 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L7FGB-0002RR-9X for qemu-devel@nongnu.org; Mon, 01 Dec 2008 15:20:48 -0500 Received: from [199.232.76.173] (port=35224 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7FGB-0002R8-3r for qemu-devel@nongnu.org; Mon, 01 Dec 2008 15:20:47 -0500 Received: from an-out-0708.google.com ([209.85.132.248]:58732) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L7FGA-0002sf-OB for qemu-devel@nongnu.org; Mon, 01 Dec 2008 15:20:46 -0500 Received: by an-out-0708.google.com with SMTP id c38so924085ana.37 for ; Mon, 01 Dec 2008 12:20:46 -0800 (PST) Message-ID: <4934471B.30606@codemonkey.ws> Date: Mon, 01 Dec 2008 14:20:43 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1228160470-11764-1-git-send-email-glommer@redhat.com> In-Reply-To: <1228160470-11764-1-git-send-email-glommer@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] extboot: properly set int 0x13 return value Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org Glauber Costa wrote: > Callers of int 0x13 usually rely on the carry flag being > clear/set to indicate the status of the interrupt execution. > > However, our current code clear or set the flags register, > which is totally useless. Whichever value it has, will > be overwritten by the flags value _before_ the interrupt, due to > the iret instruction. > > This fixes a bug that prevents slackware (and possibly win2k, untested) > to boot. > Good catch! > Signed-off-by: Glauber Costa > > Acked-by: Anthony Liguori Regards, Anthony Liguori