From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L7FI9-0003K8-NG
	for qemu-devel@nongnu.org; Mon, 01 Dec 2008 15:22:49 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L7FI8-0003JS-Aw
	for qemu-devel@nongnu.org; Mon, 01 Dec 2008 15:22:49 -0500
Received: from [199.232.76.173] (port=58145 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L7FI7-0003JJ-UD
	for qemu-devel@nongnu.org; Mon, 01 Dec 2008 15:22:47 -0500
Received: from e4.ny.us.ibm.com ([32.97.182.144]:58920)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1L7FI7-00030r-6g
	for qemu-devel@nongnu.org; Mon, 01 Dec 2008 15:22:47 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id mB1KMKgU003964
	for <qemu-devel@nongnu.org>; Mon, 1 Dec 2008 15:22:20 -0500
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	mB1KMjnF169394
	for <qemu-devel@nongnu.org>; Mon, 1 Dec 2008 15:22:45 -0500
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	mB1KMipb029068
	for <qemu-devel@nongnu.org>; Mon, 1 Dec 2008 15:22:44 -0500
Message-ID: <49344792.9070509@us.ibm.com>
Date: Mon, 01 Dec 2008 14:22:42 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] Virtio block device support
References: <1227650239-14162-1-git-send-email-aliguori@us.ibm.com>
	<1227650239-14162-2-git-send-email-aliguori@us.ibm.com>
	<1228162828.14874.58.camel@localhost.localdomain>
In-Reply-To: <1228162828.14874.58.camel@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>

Hollis Blanchard wrote:
> On Tue, 2008-11-25 at 15:57 -0600, Anthony Liguori wrote:
>   
>> diff --git a/hw/pc.h b/hw/pc.h
>> index f156b9e..bbfa2d6 100644
>> --- a/hw/pc.h
>> +++ b/hw/pc.h
>> @@ -152,4 +152,8 @@ void pci_piix4_ide_init(PCIBus *bus,
>> BlockDriverState **hd_table, int devfn,
>>
>>  void isa_ne2000_init(int base, qemu_irq irq, NICInfo *nd);
>>
>> +/* virtio-blk.c */
>> +void *virtio_blk_init(PCIBus *bus, uint16_t vendor, uint16_t device,
>> +                      BlockDriverState *bs);
>> +
>>  #endif
>>     
>
> This shouldn't be in pc.h.

I don't disagree.

>  I don't know if you'd consider virtio.h to be
> a layering violation, but the virtio layers are already being compressed
> in these patches...
>   

Yeah, I think the virtio stuff could use some love but I'd like to avoid 
that until we have something in tree and merged against kvm-userspace.

Regards,

Anthony Liguori