From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L7atb-00076z-NE
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 14:26:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L7ata-00076X-Vj
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 14:26:55 -0500
Received: from [199.232.76.173] (port=46297 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L7ata-00076P-Qf
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 14:26:54 -0500
Received: from yx-out-1718.google.com ([74.125.44.158]:43342)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L7ata-0008IO-HE
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 14:26:54 -0500
Received: by yx-out-1718.google.com with SMTP id 3so1220716yxi.82
	for <qemu-devel@nongnu.org>; Tue, 02 Dec 2008 11:26:54 -0800 (PST)
Message-ID: <49358BFA.5060702@codemonkey.ws>
Date: Tue, 02 Dec 2008 13:26:50 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2 of 7] [UPDATE]  remove bgr
References: <492D8BA4.4060504@eu.citrix.com>
In-Reply-To: <492D8BA4.4060504@eu.citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Stefano Stabellini wrote:
> Do not handle bgr host displays in the backends.
>
> Right now a bgr flag exists so that sdl can set it, if the SDL_Surface
> is bgr.
> Afterwards the graphic device (e.g. vga.c) does the needed conversion.
>
> With this patch series is sdl that is responsible for rendering the format
> provided by the graphic device that must provide a DisplaySurface
> (ds->surface) in 16 or 32 bpp, rgb.
> Afterwards sdl creates a SDL_Surface from the given DisplaySurface and
> blits it into the main SDL_Surface using SDL_BlitSurface.
>
> Everything is handled by sdl transparently, because SDL_BlitSurface is
> perfectly capable of handling bgr displays by itself.
>
> Compared to the last version few more "if (bgr)" have been removed in
> hw/sm501.c.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>   

This breaks bgr support until the additional patches, correct?

Regards,

Anthony Liguori