From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L7azy-0000UB-1z
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 14:33:30 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L7azx-0000Ti-Cq
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 14:33:29 -0500
Received: from [199.232.76.173] (port=51845 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L7azx-0000Tc-4o
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 14:33:29 -0500
Received: from qw-out-1920.google.com ([74.125.92.149]:27547)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L7azw-0000Xy-QE
	for qemu-devel@nongnu.org; Tue, 02 Dec 2008 14:33:28 -0500
Received: by qw-out-1920.google.com with SMTP id 5so938169qwc.4
	for <qemu-devel@nongnu.org>; Tue, 02 Dec 2008 11:33:27 -0800 (PST)
Message-ID: <49358D84.5060409@codemonkey.ws>
Date: Tue, 02 Dec 2008 13:33:24 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0 of 7] [UPDATE] DisplayState interface change
References: <492D8B94.4000805@eu.citrix.com>
In-Reply-To: <492D8B94.4000805@eu.citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Stefano Stabellini wrote:
> Hi all,
> this is the third update of the "DisplayState interface change" series.
>
> The series is now of made of 7 patches:
>
> 1) accessors again
> some other substitutions in hw/sm501.c;
>
> 2) remove bgr
> the new DisplayState interface does not contain any host specific
> display detail, it is an abstraction of the backend display, hence we
> don't need to memorize the bgr flag in DisplayState.
> The frontend must be able to handle a bgr display by itself, in fact sdl
> is perfectly capable of that;
>
> 3) DisplayState interface change
> this is the big patch that actually changes the interface;
>
> 4) vnc improvements
> this patch introduces DisplaySurfaces in vnc, simplifying the code.
>
> 5) graphical_console_init change
> this is the patch that changes the graphical_console_init function
> to return an allocated DisplayState instead of a QEMUConsole, as Anthony
> suggested.
> This patch does *not* include any required changes to any devices, these
> changes come with the two following patches.
>
> 6) machine changes
> this patch changes the QEMUMachine init functions of all the machine types
> not to take a DisplayState as an argument because is not needed any
> more;
>
> 7) graphic device changes
> this patch updates the graphic device code to use the new
> graphical_console_init function.
>
> Patch number 5 requires also 6 and 7 to compile.
>
> More comments on single patches.
>   

Except for the few comments I've made, I think this series looks good.  
Once you fix the problems I've pointed out, I'll do a thorough test run 
through each patch and unless there are major objections, push the series.

Regards,

Anthony Liguori

> Cheers,
>
> Stefano
>
>
>
>
>
>