From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L7b2O-0001WM-M4 for qemu-devel@nongnu.org; Tue, 02 Dec 2008 14:36:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L7b2M-0001VX-V1 for qemu-devel@nongnu.org; Tue, 02 Dec 2008 14:35:59 -0500 Received: from [199.232.76.173] (port=40850 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7b2M-0001VK-RL for qemu-devel@nongnu.org; Tue, 02 Dec 2008 14:35:58 -0500 Received: from qw-out-1920.google.com ([74.125.92.149]:27846) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L7b2M-0000qP-I8 for qemu-devel@nongnu.org; Tue, 02 Dec 2008 14:35:58 -0500 Received: by qw-out-1920.google.com with SMTP id 5so938515qwc.4 for ; Tue, 02 Dec 2008 11:35:58 -0800 (PST) Message-ID: <49358E1A.9000001@codemonkey.ws> Date: Tue, 02 Dec 2008 13:35:54 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0 of 7] [UPDATE] DisplayState interface change References: <492D8B94.4000805@eu.citrix.com> <492D9EA4.9050008@eu.citrix.com> <492F3074.6060200@codemonkey.ws> <200811280029.57082.paul@codesourcery.com> In-Reply-To: <200811280029.57082.paul@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org, Stefano Stabellini Paul Brook wrote: > > Something like that, yes. > > My understanding was that the plan is to have one DisplayState per image > source. At that point the device doesn't care whether it's "active" or not > (inactive DisplayStates will be the equivalent of /dev/null). > If we still have a single DisplayState shared by multiple sources then > is_graphics_console is not a sufficient check to tell whether the VGA device > is active. > > I'm not sure that removing QEMUConsole without adding multiple DisplayStates > is feasible. > I think this patch series is a big step in this direction. The is_graphics_console is an artifact. What we need to follow up this series with, is adding keyboard/mouse input to DisplayState, and pushing all the virtual terminal switching into TextConsole and cleaning TextConsole up to be a more clean virtual KVM. If noone else takes this on, I'll add it to my queue. I think it's a follow up series though to this one. Regards, Anthony Liguori > Paul >