From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L8KLo-00005U-ET
	for qemu-devel@nongnu.org; Thu, 04 Dec 2008 14:59:04 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L8KLm-0008WL-Ov
	for qemu-devel@nongnu.org; Thu, 04 Dec 2008 14:59:04 -0500
Received: from [199.232.76.173] (port=56049 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L8KLm-0008WG-Hh
	for qemu-devel@nongnu.org; Thu, 04 Dec 2008 14:59:02 -0500
Received: from e6.ny.us.ibm.com ([32.97.182.146]:34467)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1L8KLm-0002MX-4Q
	for qemu-devel@nongnu.org; Thu, 04 Dec 2008 14:59:02 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e6.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id mB4JwT49030864
	for <qemu-devel@nongnu.org>; Thu, 4 Dec 2008 14:58:29 -0500
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	mB4Jwx66175396
	for <qemu-devel@nongnu.org>; Thu, 4 Dec 2008 14:58:59 -0500
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	mB4JwV2t006417
	for <qemu-devel@nongnu.org>; Thu, 4 Dec 2008 14:58:31 -0500
Message-ID: <49383682.10309@us.ibm.com>
Date: Thu, 04 Dec 2008 13:58:58 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1227650239-14162-1-git-send-email-aliguori@us.ibm.com>
	<1228155570-9913-1-git-send-email-hollisb@us.ibm.com>
In-Reply-To: <1228155570-9913-1-git-send-email-hollisb@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] [v2] Remove TARGET_PAGE_SIZE from virtio
	interface
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>

Hollis Blanchard wrote:
> TARGET_PAGE_SIZE should only be used internal to qemu, not in guest/host
> interfaces. The virtio frontend code in Linux uses two constants (PFN shift
> and vring alignment) for the interface, so update qemu to match.
>
> I've tested this with PowerPC KVM and confirmed that it fixes virtio problems
> when using non-TARGET_PAGE_SIZE pages in the guest.
>   

Applied.  Thanks.

Regards,

Anthony Liguori