From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L8Mof-0004vY-W0 for qemu-devel@nongnu.org; Thu, 04 Dec 2008 17:37:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L8Moe-0004uq-ID for qemu-devel@nongnu.org; Thu, 04 Dec 2008 17:37:01 -0500 Received: from [199.232.76.173] (port=58510 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L8Moe-0004uk-73 for qemu-devel@nongnu.org; Thu, 04 Dec 2008 17:37:00 -0500 Received: from mail-qy0-f20.google.com ([209.85.221.20]:47209) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L8Mod-0001QL-UV for qemu-devel@nongnu.org; Thu, 04 Dec 2008 17:37:00 -0500 Received: by qyk13 with SMTP id 13so7481961qyk.10 for ; Thu, 04 Dec 2008 14:36:58 -0800 (PST) Message-ID: <49385B86.8090604@codemonkey.ws> Date: Thu, 04 Dec 2008 16:36:54 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1228427046-28875-1-git-send-email-glommer@redhat.com> In-Reply-To: <1228427046-28875-1-git-send-email-glommer@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] do boundary check based on absolute value Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com Glauber Costa wrote: > For backward operations, dstpitch and srcpitch can > be negative. This leads BLTUNSAFE macro into an > overflow, and as a result, it avoids performing > operations that are perfectly valid. > > The visible effect that led to that patch was the gnome-panel > bar in Fedora10. Before this patch, you could see garbage > clobbering a big portion of the bar. > > After this patch, this garbage is gone. > > Applied. Thanks. Regards, Anthony Liguori