From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [5876] hw/apic.c: use fls() from host-utils
Date: Fri, 05 Dec 2008 14:39:16 -0600 [thread overview]
Message-ID: <49399174.10806@codemonkey.ws> (raw)
In-Reply-To: <E1L8LFu-0000Qp-Qj@cvs.savannah.gnu.org>
Aurelien Jarno wrote:
> Revision: 5876
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5876
> Author: aurel32
> Date: 2008-12-04 20:57:02 +0000 (Thu, 04 Dec 2008)
>
> Log Message:
> -----------
> hw/apic.c: use fls() from host-utils
>
> ...and fix a bug, the implementation in hw/apic.c was wrong.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
I just bisected a broken Linux guest to this changeset. I think it
should be fls() - 1.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-12-05 20:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 20:57 [Qemu-devel] [5876] hw/apic.c: use fls() from host-utils Aurelien Jarno
2008-12-05 20:39 ` Anthony Liguori [this message]
2008-12-06 10:48 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49399174.10806@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).