From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L8hSN-0001OZ-T7
	for qemu-devel@nongnu.org; Fri, 05 Dec 2008 15:39:23 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L8hSM-0001O5-AH
	for qemu-devel@nongnu.org; Fri, 05 Dec 2008 15:39:23 -0500
Received: from [199.232.76.173] (port=49805 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L8hSM-0001O1-43
	for qemu-devel@nongnu.org; Fri, 05 Dec 2008 15:39:22 -0500
Received: from yx-out-1718.google.com ([74.125.44.152]:50148)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1L8hSL-0007rE-Mr
	for qemu-devel@nongnu.org; Fri, 05 Dec 2008 15:39:21 -0500
Received: by yx-out-1718.google.com with SMTP id 3so130226yxi.82
	for <qemu-devel@nongnu.org>; Fri, 05 Dec 2008 12:39:20 -0800 (PST)
Message-ID: <49399174.10806@codemonkey.ws>
Date: Fri, 05 Dec 2008 14:39:16 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [5876] hw/apic.c: use fls() from host-utils
References: <E1L8LFu-0000Qp-Qj@cvs.savannah.gnu.org>
In-Reply-To: <E1L8LFu-0000Qp-Qj@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>

Aurelien Jarno wrote:
> Revision: 5876
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5876
> Author:   aurel32
> Date:     2008-12-04 20:57:02 +0000 (Thu, 04 Dec 2008)
>
> Log Message:
> -----------
> hw/apic.c: use fls() from host-utils
>
> ...and fix a bug, the implementation in hw/apic.c was wrong.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>   

I just bisected a broken Linux guest to this changeset.  I think it 
should be fls() - 1.

Regards,

Anthony Liguori