[Qemu-devel] [PATCH] Fix memory-mapped i8042 on MIPS Magnum v3

[Qemu-devel] [PATCH] Fix memory-mapped i8042 on MIPS Magnum v3

[Hervé Poussineau]

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

Hi,

Current implementation of memory-mapped i8042 controller is atm 
implemented with an interface shift (it_shift) parameter, like most all 
memory-mapped devices in Qemu.
However, this isn't suitable for MIPS Magnum, where i8042 controller is 
at 0x80005000 up to 0x80005fff.

Thomas Bogendoerfer (from #mipslinux) tested the behaviour of a real 
machine, and found that odd addresses are for status/command register, 
and even addresses for data register.

Attached patch implements this behaviour by replacing the it_shift 
parameter by a mask one.
Incidentally, keyboard now works on OpenBSD 2.3, which accesses i8042 
controller at 0x80005060 and 0x80005061.

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

Changes since v1:
- updated to qemu svn

Changes since v2:
- mask type is now target_phys_addr_t. size is still a ram_addr_t, as 
cpu_register_physical_memory() requests it.

Hervé

[-- Attachment #2: pckbd_mm_v3.diff --]
[-- Type: plain/text, Size: 2825 bytes --]

Re: [Qemu-devel] [PATCH] Fix memory-mapped i8042 on MIPS Magnum v3

[Aurelien Jarno]

On Mon, Dec 08, 2008 at 11:06:51PM +0100, Hervé Poussineau wrote:
> Hi,
>
> Current implementation of memory-mapped i8042 controller is atm  
> implemented with an interface shift (it_shift) parameter, like most all  
> memory-mapped devices in Qemu.
> However, this isn't suitable for MIPS Magnum, where i8042 controller is  
> at 0x80005000 up to 0x80005fff.
>
> Thomas Bogendoerfer (from #mipslinux) tested the behaviour of a real  
> machine, and found that odd addresses are for status/command register,  
> and even addresses for data register.
>
> Attached patch implements this behaviour by replacing the it_shift  
> parameter by a mask one.
> Incidentally, keyboard now works on OpenBSD 2.3, which accesses i8042  
> controller at 0x80005060 and 0x80005061.
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>

Thanks, applied.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net