From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LA4AS-0006ds-3F for qemu-devel@nongnu.org; Tue, 09 Dec 2008 10:06:32 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LA4AO-0006ax-B3 for qemu-devel@nongnu.org; Tue, 09 Dec 2008 10:06:30 -0500 Received: from [199.232.76.173] (port=42002 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LA4AO-0006an-85 for qemu-devel@nongnu.org; Tue, 09 Dec 2008 10:06:28 -0500 Received: from an-out-0708.google.com ([209.85.132.244]:28629) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LA4AO-0003me-9n for qemu-devel@nongnu.org; Tue, 09 Dec 2008 10:06:28 -0500 Received: by an-out-0708.google.com with SMTP id c38so984487ana.37 for ; Tue, 09 Dec 2008 07:06:27 -0800 (PST) Message-ID: <493E896F.2030209@codemonkey.ws> Date: Tue, 09 Dec 2008 09:06:23 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <> <1228820143-23580-1-git-send-email-markmc@redhat.com> In-Reply-To: <1228820143-23580-1-git-send-email-markmc@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/4] Add nic link up/down emulation to e1000 Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: Rusty Russell , qemu-devel@nongnu.org, Avi Kivity Mark McLoughlin wrote: > Hi, > Here's a small patch set which adds link up/down > emulation to e1000 via a "set_link" monitor command. This is > useful for people who want to e.g. test how applications > and/or the guest OS handles this condition. > > The command itself takes a VLAN ID and device index > in order to identify which device to modify. That's a bit > lame and could clearly by improved if the overall idea was > thought to be sound. > Yeah, this series looks good (as does the virtio-net one). I plan on merging virtio-net either today or tomorrow and I can merge your virtio-net series into QEMU too. BTW, I plan on introducing qemu_sendv_packet() to QEMU in the process of this. Regards, Anthony Liguori > Thanks, > Mark. > > >