From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAKp1-0000ye-4c for qemu-devel@nongnu.org; Wed, 10 Dec 2008 03:53:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAKp0-0000yS-JK for qemu-devel@nongnu.org; Wed, 10 Dec 2008 03:53:30 -0500 Received: from [199.232.76.173] (port=49226 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAKp0-0000yP-F3 for qemu-devel@nongnu.org; Wed, 10 Dec 2008 03:53:30 -0500 Received: from mx2.redhat.com ([66.187.237.31]:47470) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LAKoz-0004F9-Ui for qemu-devel@nongnu.org; Wed, 10 Dec 2008 03:53:30 -0500 Message-ID: <493F8382.1020806@redhat.com> Date: Wed, 10 Dec 2008 10:53:22 +0200 From: Avi Kivity MIME-Version: 1.0 References: <> <1228820143-23580-1-git-send-email-markmc@redhat.com> <493E896F.2030209@codemonkey.ws> In-Reply-To: <493E896F.2030209@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/4] Add nic link up/down emulation to e1000 Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mark McLoughlin , Rusty Russell , qemu-devel@nongnu.org, Avi Kivity Anthony Liguori wrote: > Mark McLoughlin wrote: >> Hi, >> Here's a small patch set which adds link up/down >> emulation to e1000 via a "set_link" monitor command. This is >> useful for people who want to e.g. test how applications >> and/or the guest OS handles this condition. >> >> The command itself takes a VLAN ID and device index >> in order to identify which device to modify. That's a bit >> lame and could clearly by improved if the overall idea was >> thought to be sound. >> > > Yeah, this series looks good (as does the virtio-net one). I plan on > merging virtio-net either today or tomorrow and I can merge your > virtio-net series into QEMU too. Excellent. Mark, I'll get your patches from the next qemu merge. -- error compiling committee.c: too many arguments to function