[Qemu-devel] Re: [RESEND] [PATCH v2] Fix off-by-one bug limiting VNC passwords to 7 chars

[Anthony Liguori <anthony@codemonkey.ws>]

Applied.  Thanks.

Regards,

Anthony Liguori

Chris Webb wrote:
> Fix off-by-one bug limiting VNC passwords to 7 characters instead of 8
>
> monitor_readline expects buf_size to include the terminating \0, but
> do_change_vnc in monitor.c calls it as though it doesn't. The other site
> where monitor_readline reads a password (in vl.c) passes the buffer length
> correctly.
>
> Signed-off-by: Chris Webb <chris@arachsys.com>
> ---
>  monitor.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 22360fc..a252838 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -433,8 +433,7 @@ static void do_change_vnc(const char *target)
>      if (strcmp(target, "passwd") == 0 ||
>  	strcmp(target, "password") == 0) {
>  	char password[9];
> -	monitor_readline("Password: ", 1, password, sizeof(password)-1);
> -	password[sizeof(password)-1] = '\0';
> +	monitor_readline("Password: ", 1, password, sizeof(password));
>  	if (vnc_display_password(NULL, password) < 0)
>  	    term_printf("could not set VNC server password\n");
>      } else {
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>