[Qemu-devel] [PATCH 1/2] LSI53C895A: Remove current_dma_len hack

[Qemu-devel] [PATCH 1/2] LSI53C895A: Remove current_dma_len hack

[Justin Chevrier]

I've sorted out the problem with Openserver that this hack covered up. As such this hack can be removed. It currently is causing boot problems with Debian ARM and Windows XP SP3.

Changelog:

Remove current_dma_len update hack

Signed-off-by: Justin Chevrier <address@hidden>

--- hw/lsi53c895a.c     (revision 5852)
+++ hw/lsi53c895a.c     (working copy)
@@ -920,7 +920,6 @@
             break;
         case PHASE_DI:
             s->waiting = 2;
-            s->current_dma_len = s->dbc;
             lsi_do_dma(s, 0);
             if (s->waiting)
                 s->waiting = 3;



      

Re: [Qemu-devel] [PATCH 1/2] LSI53C895A: Remove current_dma_len hack

[Ryan Harper]

* Justin Chevrier <theburner1@yahoo.com> [2008-12-02 10:00]:
> I've sorted out the problem with Openserver that this hack covered up. As such this hack can be removed. It currently is causing boot problems with Debian ARM and Windows XP SP3.
> 
> Changelog:
> 
> Remove current_dma_len update hack
> 
> Signed-off-by: Justin Chevrier <address@hidden>

Acked-by: Ryan Harper <ryanh@us.ibm.com>

> 
> --- hw/lsi53c895a.c     (revision 5852)
> +++ hw/lsi53c895a.c     (working copy)
> @@ -920,7 +920,6 @@
>              break;
>          case PHASE_DI:
>              s->waiting = 2;
> -            s->current_dma_len = s->dbc;
>              lsi_do_dma(s, 0);
>              if (s->waiting)
>                  s->waiting = 3;
> 
> 
> 
>       
> 

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com

Re: [Qemu-devel] [PATCH 1/2] LSI53C895A: Remove current_dma_len hack

[Chris Wright]

* Ryan Harper (ryanh@us.ibm.com) wrote:
> * Justin Chevrier <theburner1@yahoo.com> [2008-12-02 10:00]:
> > I've sorted out the problem with Openserver that this hack covered up. As such this hack can be removed. It currently is causing boot problems with Debian ARM and Windows XP SP3.

And x86 Linux as well...

> > Changelog:
> > 
> > Remove current_dma_len update hack
> > 
> > Signed-off-by: Justin Chevrier <address@hidden>
> 
> Acked-by: Ryan Harper <ryanh@us.ibm.com>

Ack 

Came to the same conclusion last night:

 Reverting the single line (essentially the primary purpose of the
 original change):

        s->current_dma_len = s->dbc;

 Is enough to get my Linux guests working again.

  lsi_scsi: SCRIPTS dsp=f2002210 opcode 90080000 arg 00000000
  lsi_scsi: Return to 0xf20027e8
  lsi_scsi: SCRIPTS dsp=f20027e8 opcode 11000000 arg 00000350
 -lsi_scsi: DMA addr=0x000000001e0b8000 len=16
 +lsi_scsi: DMA addr=0x000000001e0b0000 len=4096


thanks,
-chris

Re: [Qemu-devel] [PATCH 1/2] LSI53C895A: Remove current_dma_len hack

[Anthony Liguori]

Justin Chevrier wrote:
> I've sorted out the problem with Openserver that this hack covered up. As such this hack can be removed. It currently is causing boot problems with Debian ARM and Windows XP SP3.
>
> Changelog:
>
> Remove current_dma_len update hack
>
> Signed-off-by: Justin Chevrier <address@hidden>
>   

I'd like to apply this, but <address@hidden> is not a valid email address.

Regards,

Anthony Liguori

> --- hw/lsi53c895a.c     (revision 5852)
> +++ hw/lsi53c895a.c     (working copy)
> @@ -920,7 +920,6 @@
>              break;
>          case PHASE_DI:
>              s->waiting = 2;
> -            s->current_dma_len = s->dbc;
>              lsi_do_dma(s, 0);
>              if (s->waiting)
>                  s->waiting = 3;
>
>
>
>       
>
>
>