From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LARA3-0004a7-R9 for qemu-devel@nongnu.org; Wed, 10 Dec 2008 10:39:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LARA2-0004Zn-Th for qemu-devel@nongnu.org; Wed, 10 Dec 2008 10:39:39 -0500 Received: from [199.232.76.173] (port=43292 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LARA2-0004Zj-Pc for qemu-devel@nongnu.org; Wed, 10 Dec 2008 10:39:38 -0500 Received: from yw-out-1718.google.com ([74.125.46.153]:20097) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LARA2-0004YS-FG for qemu-devel@nongnu.org; Wed, 10 Dec 2008 10:39:38 -0500 Received: by yw-out-1718.google.com with SMTP id 6so241731ywa.82 for ; Wed, 10 Dec 2008 07:39:38 -0800 (PST) Message-ID: <493FE2B6.8030007@codemonkey.ws> Date: Wed, 10 Dec 2008 09:39:34 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1228759670-31113-1-git-send-email-ryanh@us.ibm.com> <1228759670-31113-3-git-send-email-ryanh@us.ibm.com> In-Reply-To: <1228759670-31113-3-git-send-email-ryanh@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/4] Add 64-bit Block Move support (Direct & Table Indirect) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ryan Harper Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org Ryan Harper wrote: > This patch adds support for 64-bit Block Move instructions. There are multiple > modes for 64-bit Block moves, direct, indirect, and table indirect. This patch > implements Direct and Table indirect moves which are needed by 64-bit windows > and SYM_CONF_DMA_ADDRESSING_MODE=2 for the Linux sym53c8xx_2 driver respectively. > > Two helper functions are included to check which mode the guest is using. For > 64-bit direct moves, we fetch a 3rd DWORD and store the value in the DBMS > register. For Table Indirect moves, we look into the table for which register > contains the upper 32-bits of the 64-bit address. This selector value indicates > which register to pull the value from and into dnad64 register. > > Finally, lsi_do_dma is updated to use the approriate register to build a 64-bit > DMA address if required. > > With this patch, Windows XP x64, 2003 SP2 x64, can now install to scsi devices. > Linux SYM_CONF_DMA_ADDRESSING_MODE=2 need a quirk fixup in Patch 4 to function > properly. > > Signed-off-by: Ryan Harper Applied. Thanks. Regards, Anthony Liguori