[Qemu-devel] [PATCH] Remove redundant #ifdef _BSD

[Qemu-devel] [PATCH] Remove redundant #ifdef _BSD

[Andre Przywara]

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

Hi,

since _BSD if already handled in osdep.c:qemu_memalign(), we don't need 
to check it in the calling function again. getpagesize() is available in 
BSD.

Regards,
Andre.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
AMD Saxony Limited Liability Company & Co. KG,
Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Register Court Dresden: HRA 4896, General Partner authorized
to represent: AMD Saxony LLC (Wilmington, Delaware, US)
General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

[-- Attachment #2: rem_bsd_ifdef.patch --]
[-- Type: text/x-patch, Size: 376 bytes --]

diff -r fb954e9c4a86 osdep.c
--- a/osdep.c	Wed Dec 10 19:23:18 2008 +0100
+++ b/osdep.c	Wed Dec 10 20:19:06 2008 +0100
@@ -200,11 +200,7 @@ void *qemu_vmalloc(size_t size)
     if (kqemu_allowed)
         return kqemu_vmalloc(size);
 #endif
-#ifdef _BSD
-    return valloc(size);
-#else
     return qemu_memalign(getpagesize(), size);
-#endif
 }
 
 void qemu_vfree(void *ptr)

[Qemu-devel] Re: [PATCH] Remove redundant #ifdef _BSD

[Blue Swirl]

On 12/10/08, Andre Przywara <andre.przywara@amd.com> wrote:
> Hi,
>
>  since _BSD if already handled in osdep.c:qemu_memalign(), we don't need to
> check it in the calling function again. getpagesize() is available in BSD.
>
>  Regards,
>  Andre.
>
>  Signed-off-by: Andre Przywara <andre.przywara@amd.com>

Thanks, committed in r5983.