From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LAjip-00060p-Je
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 06:28:47 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LAjin-0005zf-TM
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 06:28:46 -0500
Received: from [199.232.76.173] (port=52599 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LAjin-0005zM-L2
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 06:28:45 -0500
Received: from smtp.eu.citrix.com ([62.200.22.115]:9784)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1LAjim-00068H-3R
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 06:28:44 -0500
Message-ID: <4940F95A.6060003@eu.citrix.com>
Date: Thu, 11 Dec 2008 11:28:26 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3 of 7] [UPDATE] DisplayState interface change
References: <492D8BB1.8040306@eu.citrix.com> <49358D02.3090703@codemonkey.ws>
In-Reply-To: <49358D02.3090703@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony Liguori wrote:

> Stefano Stabellini wrote:
>> in particular the following functions are very helpful to manage a
>> DisplaySurface:
>>
>> qemu_createDisplaySurface
>> qemu_resizeDisplaySurface
>> qemu_createDisplaySurfaceFrom
>> qemu_freeDisplaySurface
>>   
> 
> These names suck.  Please change them to something more in line with the
> rest of the code.


Are the capital letters that sucks, or the names?

qemu_create_displaysurface
qemu_resize_displaysurface
qemu_create_displaysurface_from
qemu_free_displaysurface

Are these any better?

>> diff -r f1fd23dcd333 hw/cirrus_vga.c
>> --- a/hw/cirrus_vga.c    Tue Nov 25 12:28:31 2008 +0000
>> +++ b/hw/cirrus_vga.c    Wed Nov 26 11:43:17 2008 +0000
>> @@ -789,22 +789,16 @@
>>      if (BLTUNSAFE(s))
>>          return 0;
>>  
>> -    if (s->ds->dpy_copy) {
>> -    cirrus_do_copy(s, s->cirrus_blt_dstaddr - s->start_addr,
>> -               s->cirrus_blt_srcaddr - s->start_addr,
>> -               s->cirrus_blt_width, s->cirrus_blt_height);
>> -    } else {
>> -    (*s->cirrus_rop) (s, s->vram_ptr +
>> -                (s->cirrus_blt_dstaddr & s->cirrus_addr_mask),
>> -              s->vram_ptr +
>> -                (s->cirrus_blt_srcaddr & s->cirrus_addr_mask),
>> -              s->cirrus_blt_dstpitch, s->cirrus_blt_srcpitch,
>> -              s->cirrus_blt_width, s->cirrus_blt_height);
>> +    (*s->cirrus_rop) (s, s->vram_ptr +
>> +            (s->cirrus_blt_dstaddr & s->cirrus_addr_mask),
>> +            s->vram_ptr +
>> +            (s->cirrus_blt_srcaddr & s->cirrus_addr_mask),
>> +            s->cirrus_blt_dstpitch, s->cirrus_blt_srcpitch,
>> +            s->cirrus_blt_width, s->cirrus_blt_height);
>>   
> 
> You've eliminated the dpy_copy optimization?  This is extremely
> important for VNC.
> 


My approach has been too radical.
I need to remove the memmove from vnc.c, but I should be able to keep
the dpy_copy optimization.