From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LAk8w-0006ia-SP
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 06:55:47 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LAk8v-0006ht-Ku
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 06:55:46 -0500
Received: from [199.232.76.173] (port=46605 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LAk8v-0006he-9g
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 06:55:45 -0500
Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:47589
	helo=SMTP.EU.CITRIX.COM)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1LAk8u-0001j5-Rp
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 06:55:45 -0500
Message-ID: <4940FFBF.1060308@eu.citrix.com>
Date: Thu, 11 Dec 2008 11:55:43 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0 of 7] [UPDATE] DisplayState interface change
References: <492D8B94.4000805@eu.citrix.com> <492D9EA4.9050008@eu.citrix.com>
	<492F3074.6060200@codemonkey.ws>
	<200811280029.57082.paul@codesourcery.com>
	<49358E1A.9000001@codemonkey.ws>
In-Reply-To: <49358E1A.9000001@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

Anthony Liguori wrote:

> I think this patch series is a big step in this direction.  The
> is_graphics_console is an artifact.  What we need to follow up this
> series with, is adding keyboard/mouse input to DisplayState, and pushing
> all the virtual terminal switching into TextConsole and cleaning
> TextConsole up to be a more clean virtual KVM.
> 



if it is any better I can move the is_graphic_console artifact from
vga.c to console.c:

void qemu_console_resize(DisplayState *ds, int width, int height, int bpp,
                         int linesize, uint8_t *data)
{
    TextConsole *s = get_graphic_console();
    s->g_width = width;
    s->g_height = height;
    if (is_graphic_console()) {
        if (data && (bpp == 16 || bpp == 32)) {
            qemu_freeDisplaySurface(ds->surface);
            ds->surface = qemu_createDisplaySurfaceFrom(width, height, bpp, linesize, data);
        } else {
            ds->surface = qemu_resizeDisplaySurface(ds->surface, width, height, 32, 4 * width);
        }
        dpy_resize(ds);
    }
}


of course this means changing every single call to qemu_console_resize
in qemu because the number of arguments is changed.