From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LAnGq-0004nk-N8
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 10:16:08 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LAnGp-0004mq-6D
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 10:16:08 -0500
Received: from [199.232.76.173] (port=32781 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LAnGp-0004mk-30
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 10:16:07 -0500
Received: from cantor2.suse.de ([195.135.220.15]:59528 helo=mx2.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <agraf@suse.de>) id 1LAnGo-0007n8-Ly
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 10:16:06 -0500
Message-ID: <49412EB4.7000308@suse.de>
Date: Thu, 11 Dec 2008 16:16:04 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [5860] Cleanup {alloc|get}_cluster_offset() (Gleb
	Natapov)
References: <E1L7bah-00055e-I4@cvs.savannah.gnu.org>	<493FD45B.5010500@codemonkey.ws>
	<20081211110056.GJ5555@redhat.com>
In-Reply-To: <20081211110056.GJ5555@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: gleb@redhat.com

Gleb Natapov wrote:
> On Wed, Dec 10, 2008 at 08:38:19AM -0600, Anthony Liguori wrote:
>   
>> Hi Gleb,
>>
>> Anthony Liguori wrote:
>>     
>>> Revision: 5860
>>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5860
>>> Author:   aliguori
>>> Date:     2008-12-02 20:11:27 +0000 (Tue, 02 Dec 2008)
>>>   
>>>       
>> According to https://bugzilla.novell.com/show_bug.cgi?id=457957, this  
>> changeset breaks compressed qcow2 on write and savevm.
>>
>> Can you please look into this?
>>
>>     
> Alexander, can you try the patch below?
>   

The patch seems to work just fine. Please also take a look at Kevin's
and see which one fits best. Since I'm not really into qcow2 code, I
can't tell which one  is the more accurate one.

Thanks a lot for looking so quickly into this!

Alex