From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LAnbG-0002TE-Pl
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 10:37:14 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LAnbG-0002SH-C9
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 10:37:14 -0500
Received: from [199.232.76.173] (port=57592 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LAnbF-0002S9-Vj
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 10:37:13 -0500
Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:8132
	helo=SMTP.EU.CITRIX.COM)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1LAnbF-0002lK-HP
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 10:37:13 -0500
Message-ID: <494133A8.9010607@eu.citrix.com>
Date: Thu, 11 Dec 2008 15:37:12 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0 of 7] [UPDATE] DisplayState interface change
References: <492D8B94.4000805@eu.citrix.com>
	<200812111239.41509.paul@codesourcery.com>
	<49413024.5020106@eu.citrix.com>
	<200812111529.26089.paul@codesourcery.com>
In-Reply-To: <200812111529.26089.paul@codesourcery.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

Paul Brook wrote:

> On Thursday 11 December 2008, Stefano Stabellini wrote:
>> Paul Brook wrote:
>>>> void qemu_console_resize(DisplayState *ds, int width, int height, int
>>>> bpp, int linesize, uint8_t *data)
>>>> {
>>>>     TextConsole *s = get_graphic_console();
>>>>     s->g_width = width;
>>>>     s->g_height = height;
>>>>     if (is_graphic_console()) {
>>>>         if (data && (bpp == 16 || bpp == 32)) {
>>>>             qemu_freeDisplaySurface(ds->surface);
>>>>             ds->surface = qemu_createDisplaySurfaceFrom(width, height,
>>>> bpp, linesize, data); } else {
>>>>             ds->surface = qemu_resizeDisplaySurface(ds->surface, width,
>>>> height, 32, 4 * width); }
>>>>         dpy_resize(ds);
>>>>     }
>>>> }
>>> It feels wrong to be modifying the surface here. We already have to
>>> recreate the surface when we switch consoles, so why can't we use the
>>> same code for a resize?
>> We use mostly the same code already.
> 
> Why only mostly?
> 
> IIUC if a console is resized while active you get different behavior to a 
> console that is resized when inactive, then activated. This is wrong.
> 


Are we arguing about where to put two lines of code?
I can use the same function for both even if the code is already the same.