From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pci: add default pci subsystem id for all devices.
Date: Thu, 11 Dec 2008 17:39:54 +0100 [thread overview]
Message-ID: <4941425A.4040902@gmx.net> (raw)
In-Reply-To: <49413ED7.4000807@redhat.com>
Hi,
On 11.12.2008 17:24, Gerd Hoffmann wrote:
> Has been a while since the last submission. Meanwhile the ID allocation
> has been sorted and documented (see pci-ids.txt added by the patch), so
> I hope there are no outstanding issues any more.
>
> >From 2643e6a1314ae23e2d9757d782acc9f75bd22ece Mon Sep 17 00:00:00 2001
> From: Gerd Hoffmann <kraxel@redhat.com>
> Date: Tue, 26 Aug 2008 12:34:42 +0200
> Subject: [PATCH] pci: add default pci subsystem id for all devices.
>
> This sets a default PCI subsystem ID for all emulated PCI devices. PCI
> specs require this, so do it.
>
I know of lots of recent x86 hardware where the subsystem IDs are not
set in hardware, but in the BIOS instead. That allows board vendors to
set their own subsystem IDs (usually for chipset devices) in the BIOS
even if the hardware is identical to that of other vendors.
And since the OS will never see the PCI devices without a valid
subsystem ID, I'd say setting the subsystem IDs in the BIOS is spec
compliant as well.
Have you investigated setting the subsystem IDs in the Qemu BIOS?
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
next prev parent reply other threads:[~2008-12-11 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 16:24 [Qemu-devel] [PATCH] pci: add default pci subsystem id for all devices Gerd Hoffmann
2008-12-11 16:39 ` Carl-Daniel Hailfinger [this message]
2008-12-11 17:24 ` Gerd Hoffmann
2008-12-11 17:45 ` Carl-Daniel Hailfinger
2008-12-11 18:00 ` Paul Brook
2008-12-11 21:15 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4941425A.4040902@gmx.net \
--to=c-d.hailfinger.devel.2006@gmx.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).