From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAoa4-00066r-Hd for qemu-devel@nongnu.org; Thu, 11 Dec 2008 11:40:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAoa1-00064q-HK for qemu-devel@nongnu.org; Thu, 11 Dec 2008 11:40:03 -0500 Received: from [199.232.76.173] (port=34668 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAoa0-00064K-AY for qemu-devel@nongnu.org; Thu, 11 Dec 2008 11:40:00 -0500 Received: from mail.gmx.net ([213.165.64.20]:56320) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1LAoZz-00045e-Ok for qemu-devel@nongnu.org; Thu, 11 Dec 2008 11:40:00 -0500 Message-ID: <4941425A.4040902@gmx.net> Date: Thu, 11 Dec 2008 17:39:54 +0100 From: Carl-Daniel Hailfinger MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] pci: add default pci subsystem id for all devices. References: <49413ED7.4000807@redhat.com> In-Reply-To: <49413ED7.4000807@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, On 11.12.2008 17:24, Gerd Hoffmann wrote: > Has been a while since the last submission. Meanwhile the ID allocation > has been sorted and documented (see pci-ids.txt added by the patch), so > I hope there are no outstanding issues any more. > > >From 2643e6a1314ae23e2d9757d782acc9f75bd22ece Mon Sep 17 00:00:00 2001 > From: Gerd Hoffmann > Date: Tue, 26 Aug 2008 12:34:42 +0200 > Subject: [PATCH] pci: add default pci subsystem id for all devices. > > This sets a default PCI subsystem ID for all emulated PCI devices. PCI > specs require this, so do it. > I know of lots of recent x86 hardware where the subsystem IDs are not set in hardware, but in the BIOS instead. That allows board vendors to set their own subsystem IDs (usually for chipset devices) in the BIOS even if the hardware is identical to that of other vendors. And since the OS will never see the PCI devices without a valid subsystem ID, I'd say setting the subsystem IDs in the BIOS is spec compliant as well. Have you investigated setting the subsystem IDs in the Qemu BIOS? Regards, Carl-Daniel -- http://www.hailfinger.org/