From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAsme-0007hg-Fh for qemu-devel@nongnu.org; Thu, 11 Dec 2008 16:09:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAsmd-0007gn-JS for qemu-devel@nongnu.org; Thu, 11 Dec 2008 16:09:19 -0500 Received: from [199.232.76.173] (port=34631 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAsmd-0007gg-BR for qemu-devel@nongnu.org; Thu, 11 Dec 2008 16:09:19 -0500 Received: from yx-out-1718.google.com ([74.125.44.156]:55555) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LAsmc-0007x6-Ue for qemu-devel@nongnu.org; Thu, 11 Dec 2008 16:09:19 -0500 Received: by yx-out-1718.google.com with SMTP id 3so525761yxi.82 for ; Thu, 11 Dec 2008 13:09:17 -0800 (PST) Message-ID: <49418179.4090800@codemonkey.ws> Date: Thu, 11 Dec 2008 15:09:13 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] snapshot subcommand for qemu-img References: <493D3774.5020508@suse.de> In-Reply-To: <493D3774.5020508@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Kevin Wolf wrote: > Add snapshot subcommand to qemu-img which allows to list, create, apply > and delete snapshots on qcow2 images. > > Signed-off-by: Kevin Wolf > This introduces a warning that gettimeofday is implicit. You can avoid the #ifdef _WIN32 by just using qemu_gettimeofday from osdep.h and also avoid the warning in the process. Regards, Anthony Liguori