From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LB93J-0003uP-NQ for qemu-devel@nongnu.org; Fri, 12 Dec 2008 09:31:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LB93I-0003tx-8v for qemu-devel@nongnu.org; Fri, 12 Dec 2008 09:31:37 -0500 Received: from [199.232.76.173] (port=39065 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LB93I-0003tu-3o for qemu-devel@nongnu.org; Fri, 12 Dec 2008 09:31:36 -0500 Received: from yw-out-1718.google.com ([74.125.46.157]:13737) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LB93H-00046L-L5 for qemu-devel@nongnu.org; Fri, 12 Dec 2008 09:31:35 -0500 Received: by yw-out-1718.google.com with SMTP id 6so666410ywa.82 for ; Fri, 12 Dec 2008 06:31:33 -0800 (PST) Message-ID: <494275C1.7000907@codemonkey.ws> Date: Fri, 12 Dec 2008 08:31:29 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 01/13] hw/ppc.c: LOG_IRQ macro References: <1228933464-7670-1-git-send-email-ehabkost@redhat.com> <1228933464-7670-2-git-send-email-ehabkost@redhat.com> <494189E9.4040007@codemonkey.ws> <95DE7E4E-25A2-4D0C-9A59-FBDCE503522E@web.de> In-Reply-To: <95DE7E4E-25A2-4D0C-9A59-FBDCE503522E@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Eduardo Habkost Andreas Färber wrote: > > Am 11.12.2008 um 22:45 schrieb Anthony Liguori: > >> Eduardo Habkost wrote: >>> This macro will avoid some #ifdefs in the code and create a single >>> point >>> where the logging call can be changed in the future. >>> >>> Signed-off-by: Eduardo Habkost >>> --- >>> hw/ppc.c | 10 ++++++++++ >>> 1 files changed, 10 insertions(+), 0 deletions(-) >>> >>> diff --git a/hw/ppc.c b/hw/ppc.c >>> index 60d6e86..cbd69e0 100644 >>> --- a/hw/ppc.c >>> +++ b/hw/ppc.c >>> @@ -31,6 +31,16 @@ >>> //#define PPC_DEBUG_IRQ >>> //#define PPC_DEBUG_TB >>> +#ifdef PPC_DEBUG_IRQ >>> +# define LOG_IRQ(...) do { \ >>> + if (loglevel & CPU_LOG_INT) \ >>> + fprintf(logfile, __VA_ARGS__); \ >>> + } while (0) >>> +#else >>> +# define LOG_IRQ(...) do { } while (0) >>> +#endif >>> >> >> This style of macro is less ideal than: >> >> #define LOG_IRQ(fmt, ...) fprintf(logfile, fmt, ## __VA_ARGS__). > > Now that the TCG conversion is done, does QEMU still require GCC? I > remember we had issues with such macros in Mono's eGLib due to some > compilers needing "fmt..." instead of "fmt, ..." and some not > supporting "__VA_ARGS__" but "...". fmt... is an old GCC-ism. __VA_ARGS__ is C99. Eduardo's syntax (w/o ##) is actually stricter C99 as ## is a GCC extension. However, I think it's a pretty good one. In terms of QEMU requiring GCC, I personally would like to maintain the status quo. C99 whenever possible with judicious use of GCC extensions when they're necessary. If someone wants to do the work to port to another compiler, posts the patches, and is willing to maintain that support (which means constant testing and nagging), we can re-examine our GCC dependency. It's not worth debating about (GCC dependency) unless someone is really going to put in the work of maintaining another compiler. Regards, Anhtony Liguori > > It might make sense then to put such logging macros in a central place > (qemu-common.h?) to avoid having to cope with such annoyances in all > those source files. > > Andreas > >