From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBQj0-0005ax-Nu for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:23:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBQiz-0005al-AC for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:23:50 -0500 Received: from [199.232.76.173] (port=57311 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBQiy-0005ai-RJ for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:23:49 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:60850) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LBQiy-0007gJ-BP for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:23:48 -0500 Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172]) by fmmailgate01.web.de (Postfix) with ESMTP id 8FBDBFA84440 for ; Sat, 13 Dec 2008 10:23:36 +0100 (CET) Received: from [88.64.11.10] (helo=[192.168.1.198]) by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1LBQim-0005sw-00 for qemu-devel@nongnu.org; Sat, 13 Dec 2008 10:23:36 +0100 Message-ID: <49437EF9.6000704@web.de> Date: Sat, 13 Dec 2008 10:23:05 +0100 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigC7B960B2CE2D68B9EAD5430E" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [5998] Fix TARGET_LONG_BITS warning in TCG Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC7B960B2CE2D68B9EAD5430E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Blue Swirl wrote: > Revision: 5998 > http://svn.sv.gnu.org/viewvc/?view=3Drev&root=3Dqemu&revision= =3D5998 > Author: blueswir1 > Date: 2008-12-13 08:16:43 +0000 (Sat, 13 Dec 2008) >=20 > Log Message: > ----------- > Fix TARGET_LONG_BITS warning in TCG >=20 > Looking at tcg/tcg.c:828, the bug that the warning indicated would show= up as > incorrect PC shown in log, only on 32 bit big endian host emulating a 6= 4 bit > target, -d op flag enabled. Now that dyngen is gone, the patch can be a= pplied. >=20 > Modified Paths: > -------------- > trunk/tcg/tcg-runtime.c >=20 > Modified: trunk/tcg/tcg-runtime.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- trunk/tcg/tcg-runtime.c 2008-12-12 20:02:52 UTC (rev 5997) > +++ trunk/tcg/tcg-runtime.c 2008-12-13 08:16:43 UTC (rev 5998) > @@ -29,6 +29,7 @@ > =20 > #include "config.h" > #include "osdep.h" > +#include "cpu.h" // For TARGET_LONG_BITS > #include "tcg.h" > =20 > int64_t tcg_helper_shl_i64(int64_t arg1, int64_t arg2) >=20 Nice that this warning is finally fixed - but what is the point of including all those headers at all here? [1] worked well for me while reducing dependencies. Jan [1] http://permalink.gmane.org/gmane.comp.emulators.qemu/32076 --------------enigC7B960B2CE2D68B9EAD5430E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAklDfv0ACgkQniDOoMHTA+mL9QCdG+59vXb3R3sB5w4wOTHZpvUm 3d0An3UnNXbMq3OLazcv3K1p+fucJ1ih =ujkY -----END PGP SIGNATURE----- --------------enigC7B960B2CE2D68B9EAD5430E--